Re: [PATCH 3/3] dt-bindings: phy: add definition for MSM8960

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 28/07/2022 15:54, Shinjo Park wrote:
> Hello Krzysztof,
> 
> Sorry for any confusion during my first patch submission.
> 
> PATCH 1:
>>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.
>>
>> You add label, not change something.
> 
>>> - sleep_clk {
> 
>>> + sleep_clk: sleep_clk {
> 
>>
> 
>> Since you touch the line, make the device node sleep-clk (device node
> 
>> names should not have underscores) and mention this in commit msg.
> 
> 
> I can change the line into "sleep_clk: sleep-clk". And the commit message
> would be "Change the device node of sleep_clk to sleep-clk and add a
> label"? Another problem is that in the same .dtsi file there are other
> device nodes containing underscores (cxo_board, pxo_board). Should I also
> change these in the patch?
> 
> PATCH 2:
>>> +                     phy-names = "usb-phy";
>>> +                     status = "disabled";
>>
>> status is the last property.
>>
>>> +                     #reset-cells = <1>;
> 
> I can move #reset-cells one line up and make the status last line. On the
> other hand, the same definition is also used in
> arch/arm/boot/dts/qcom-apq8064.dtsi (also the clock definition mentioned in
> PATCH 1). Shall I include another patch for that file in the next revision
> of this patch series?


Yes, you can rename them in other patch as well.

> 
> PATH 3:
>> 1. Thread your submissions.
> 
> Shall I use this thread for all follow-ups for my first and second patch?

No. One patchset, one thread.

https://elixir.bootlin.com/linux/v5.19-rc5/source/Documentation/process/5.Posting.rst

> 
>> 2. Use subject prefix matching the file.
> 
> If I understood correctly, then this should be "dt-bindings: phy:
> qcom,usb-hs-phy:"?

Yes.


Best regards,
Krzysztof