From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5208C43219 for ; Tue, 26 Apr 2022 06:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245449AbiDZGnX (ORCPT ); Tue, 26 Apr 2022 02:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245399AbiDZGnU (ORCPT ); Tue, 26 Apr 2022 02:43:20 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F16F76374 for ; Mon, 25 Apr 2022 23:40:12 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id g6so11176963ejw.1 for ; Mon, 25 Apr 2022 23:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YQBirjcHw1XssjMgenO6HRfRZsWWatGT2BxMsOHFYCE=; b=IBjeDJUQPPgNrNiqtJATmu07ecSQmbmK+jJQ9Qkqm68KYBT2mZNkWUVJVPy5PP28iC ZZ5YiSPdZxmlFb9F21Hv6A+edHNDWn1wc2SnbnTRFUMJQVRVZYnI6etGe9iHNhOZg5fG RMKKEG/rXDg2iKI6iDxzFMiZH+w+BxAN7X+a15HLRXcrIZBPXGDDzgfbFlnhh5Mo+Xwc 5QLsw9I2ampq1hTraxXnKTLSoGq6LkPZCV7WBSQhuah3W2lWXHHgu1iftsIPNLV/YbGG MGepN8bjr7Iauo5KoUBkHqk4ReN7oFG+cfLmxYq0peiDALMtxKCbbfG3TQ89HGsNxOcy k0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YQBirjcHw1XssjMgenO6HRfRZsWWatGT2BxMsOHFYCE=; b=fLN7WfJojOVvhF+5+PHC1qeEkvYOOQ8/QCQBVr2drK+IwL4LMI5VtW01aZO0Bh/SB8 cGE2LcN0ULhXJTpZ3oZd6a7aCvD9PNXGU50ybiU5NDLulUd6+ZUa1l2cr/KUIxzGLJ7y 5Ij0vMCwSM8ZYZ3uP6mbCcOSN3WQBenkhZ75PfTAUp/beONYH5k/iuY7+v7stk3Qtupa CBg482vi7DQm9eOkvuhwk2RslWyGud+xUHcTMiPgqcjZtsOf+ibsr3GQ2iw3o5Ae2qE1 SKIphA9ukQBHiDyxoXsXBXJdMWLWZX+je++Xy9uv7fn07wklO79dBpf3iKuc4lecBy/C jnWw== X-Gm-Message-State: AOAM533/g7Fg6fJZUkLKOoDmxmiiPxv6qh4Yh+2Dj+o/Gy9+qkmzK9/a LQYrmnWcZNNVKlDQ09lqeo8q48x5G8H1xQ== X-Google-Smtp-Source: ABdhPJxZhXFQhcEzCB8B5dlgOiWdecKG+rf6v1oIMQ4/m9NvZbzVShnAUy6VkZ6totD6LEgaHzmIYQ== X-Received: by 2002:a17:907:8a0d:b0:6f3:a595:6136 with SMTP id sc13-20020a1709078a0d00b006f3a5956136mr4544804ejc.54.1650955211482; Mon, 25 Apr 2022 23:40:11 -0700 (PDT) Received: from [192.168.0.244] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id r13-20020a508d8d000000b00425d3555fc6sm4309024edh.30.2022.04.25.23.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 23:40:11 -0700 (PDT) Message-ID: <8498c0b4-ed1f-b4a0-d53c-a7addf75ea66@linaro.org> Date: Tue, 26 Apr 2022 08:40:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084 Content-Language: en-US To: Stephen Boyd , Andy Gross , Ansuel Smith , Bjorn Andersson , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Taniya Das , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220425204001.710238-1-krzysztof.kozlowski@linaro.org> <20220425224000.CB7F3C385A4@smtp.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220425224000.CB7F3C385A4@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/04/2022 00:39, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2022-04-25 13:40:01) >> The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084 >> should have slightly different bindings (without Qualcomm thermal sensor >> device). >> >> Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation") >> Reported-by: Rob Herring >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/clock/qcom,gcc-apq8064.yaml | 4 +- >> .../bindings/clock/qcom,gcc-apq8084.yaml | 42 +++++++++++++++++++ >> 2 files changed, 43 insertions(+), 3 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > > If it's generated with 'format-patch -C -M' does it detect the copy? Nope, and I think these are default. The files are not that similar, because while copying I cleaned it up. format-patch -C20% -M20% also does not detect it. Only `git format-patch -1 -C20% -M20% --find-copies-harder` detects a copy. I will use it, but you won't see nice copy-patch. > >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml >> new file mode 100644 >> index 000000000000..63d08e82b3d8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml >> @@ -0,0 +1,42 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,gcc-apq8084.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Global Clock & Reset Controller Binding for APQ8084 >> + >> +maintainers: >> + - Stephen Boyd >> + - Taniya Das > > Please fix Taniya's email quic_tdas@quicinc.com I wished Codeaurora/QUIC folks updated their emails all over the tree because otherwise it looks like they do not want or cannot maintain these files. Best regards, Krzysztof