From: Andrew Davis <afd@ti.com>
To: Nathan Morrisson <nmorrisson@phytec.com>, <nm@ti.com>,
<vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<upstream@lists.phytec.de>, <w.egorov@phytec.de>
Subject: Re: [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x ***
Date: Mon, 18 Dec 2023 13:41:31 -0600 [thread overview]
Message-ID: <849f7785-547c-4add-8bfd-c04608b3fbab@ti.com> (raw)
In-Reply-To: <d03e3dfc-ba3c-4474-8094-94c5557021f2@phytec.com>
On 12/18/23 12:47 PM, Nathan Morrisson wrote:
> Hi Andrew,
>
> We are adding the nodes directly to the device tree to match what is done in other device trees, for example: k3-am642-tqma64xxl.dtsi. You are correct that this could be done by the bootloader instead though. Why do you prefer having the bootloader add the nodes?
>
k3-am642-tqma64xxl.dtsi should be fixed, it slipped past me and
shouldn't be used as a reference.
The bootloader might not fill it out at all, what if we start
using the new MTD GPT partitions? Then the new bootloaders
will have to start *removing* these stale half-nodes.
If the bootloader is going to add fixed partitions it should do
the whole job. There is no good reason to have a half complete
nodes here.
Andrew
> Regards,
>
> Nathan
>
> On 12/15/23 11:20 AM, Andrew Davis wrote:
>> On 12/15/23 1:18 PM, Nathan Morrisson wrote:
>>> Add a fixed-partitions node to the NOR flash of the phyCORE-AM62x
>>> and phyCORE-AM64x to enable the bootloader to fixup the partitions
>>> during boot.
>>>
>>
>> Why can't your bootloader add these nodes?
>>
>> Andrew
>>
>>> Nathan Morrisson (2):
>>> arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash
>>> arm64: dts: ti: k3-am64-phycore-som: Add fixed-partitions to NOR Flash
>>>
>>> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 6 ++++++
>>> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 6 ++++++
>>> 2 files changed, 12 insertions(+)
>>>
prev parent reply other threads:[~2023-12-18 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 19:18 [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Nathan Morrisson
2023-12-15 19:18 ` [PATCH 1/2] arm64: dts: ti: k3-am62-phycore-som: Add fixed-partitions to NOR Flash Nathan Morrisson
2023-12-15 19:18 ` [PATCH 2/2] arm64: dts: ti: k3-am64-phycore-som: " Nathan Morrisson
2023-12-15 19:20 ` [PATCH 0/2] *** Add fixed-paritions to phyCORE-AM62x and phyCORE-AM64x *** Andrew Davis
2023-12-18 18:47 ` Nathan Morrisson
2023-12-18 19:41 ` Andrew Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=849f7785-547c-4add-8bfd-c04608b3fbab@ti.com \
--to=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nmorrisson@phytec.com \
--cc=robh+dt@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox