From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33ADC36E47A for ; Fri, 25 Sep 2026 07:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790321028; cv=none; b=YB4jXjPCsLWsou4hZyoeBiYiS5mIslI29s4cc/Vu83FtZObEHKMI/R9vVUafNQVvZZUFSzy9M9iXDRGGt3fTOfOt7QKHYbV5vQXW+yxCa8j+j2s6nCYt/A6komuDSJAmQM7RyhdISE7ws+cCCH00rw9ERqRmQ5NJ+Y9K5lwoqxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790321028; c=relaxed/simple; bh=TtAFYlXaYEptlGZE+r/oa4Q4G8MLw90q0w9FU1D5r90=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FHNP8G6ZjB/RYMSkdLntXBG0TiynOVhlpZ2S8WAAA4O0rR59CR2fHyBygJZDcdK36/DMYXpE3EP4SqYfBpTuYi2OGN5qERCjiEv+d/gQ4epKypD3BeZ6+BHT8tO2VmWKCsbl/JqK+AklmZ3ZRjeAPStZk25WmyVMyWtSy3jB1Bo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P9mdq6/f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=keo80uSi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P9mdq6/f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="keo80uSi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68P5JXOS3628372 for ; Fri, 25 Sep 2026 07:23:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /JWi2njSoZ1wwDKZqga17FGTzS6i+4DFrIsYJdf6ZXs=; b=P9mdq6/ftwv9Xgh1 k/JvJCQdW7gvY/IHqEXWpos518FR0PWh5pviYAbihZkuP9cI+rnsBeJgoxK12Bmk ZE/sQ2NGIJRhPQ5BzcAaqp9E58DNeptauTZwJRO0XLvClLq+kTDGDd0mhtiRePPv ofFSipzHR8WoW1MrjQsuXkl6Nl1UvNeHsX2O9w6XbFqvN77kfHmiMMHL3jJYw79n r8MyRv15wjb+Sc/9pQj/Qj38DTtEShqNHtlxhGW0H6epvb94uv5AKcuYruL17eQH 8HVNmy/yp0NKTOKq6pHT7uiQtBod9LXzCbz0Sn1qbdFNLtzyKAJpd9Y+KKk/pVdA AvbU/A== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gwjq38bb3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 25 Sep 2026 07:23:45 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-331b2ec616fso2276937eec.1 for ; Fri, 25 Sep 2026 00:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790321025; x=1790925825; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/JWi2njSoZ1wwDKZqga17FGTzS6i+4DFrIsYJdf6ZXs=; b=keo80uSiZ7hON2DZmb47qRr+Yy8Wrq9NbXiMoitZZSqUCPXuTT9NHak6iJfPy0fLFk QApt9E31DqmajghtX9YYh750BIOKyzk0MMP0ffzUAXw2w+a7yrIu4fvkzeM+T0/Gl1MX MDjTOs1qXthGuQ52DPINStI373LAUKFoKKxrIi+iTNlut9RyAsRvR7ISC4ZJFAOgiMYj fr4oRRuPl0w64iVKNwXuHoapCgjOhX+Y5c1S6UbHgwDa+QubyFJUyoWYIay6lIcrwa/S PvMupumW2RXAlaVd27KOZzk90RfEVaoI4/SrVeGY7FqfM3dX/Y3XGTq1DCzexh6u+BKu QSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790321025; x=1790925825; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/JWi2njSoZ1wwDKZqga17FGTzS6i+4DFrIsYJdf6ZXs=; b=dF1d8GKhScSqS4jfElxAZwpzeSVS1bN54WrRwK6VZrRyxQu84DqpdMWrDmyeqOP4fm pqbFud7elQtWLUZN7HqhfhKT2wuDwGWE0E1g9MdBLubr/i3lnYIwuLROatF3JNn8JHgS NJaaRyuqyemU2Iqa3dca1safV0lttUTZLWCMErZ2r6s7QgfSQOCqoL0kYSFpUhHsD8/o Rz1FOABPvRRmslRqbDhTHN0tkZ8oLYw3KFrneeDYHulT+wXSwIcCEYMfmQTN59xKplbm svmsXEr8L7+AUeNpFApnhleuNLKqdMRJRmcqysIiRpby+KdNoZ850quZVLz17Euylgn2 Wh/w== X-Forwarded-Encrypted: i=1; AKwUvBwWnE7blNR0pm1kBwcRTgHWhzFND8HJs+gsnNN/oqmMhpU/pz9w6HBHjBsKFLtgeNntXgz0Ftl28XYX@vger.kernel.org X-Gm-Message-State: AFuF++kXwkfmofRw5SfF5QN7aZt+DWSdfAe6zNhWDUhKtOj6Q4VIzMLC rPYFAnvJyWzfRB7nUMrsWGoefkoNdGwYbQ6WTgnaoI5JWAw3CqP9CFBjBmWKjRfVMjRJvXb70VN auQ/VCUNAbRcISB4NHVBKv8JH9seGn99kO9Vr6qzd0YTZQ1HPCgnK5OQQjAzZBx3GoDnnCqkr X-Gm-Gg: AYBFou3LFp21JiNZW0JwTCIieAI4cu3EeJJ35nFsVS/WCXvagcRYLzw3Zlj74C+Bw2S AsE2VevfOHAx0VyjDWzoeAzHRs8GtTjIFOXJ26cPGjUF6wAPZEeJSXWLS2mQf6syG4VjCGKxsZ0 9buOJEapDL96wTOIOTVCDyNXFn0RdKCGxwq8osB9XHstH7W/Q9HRGlJbQabuR8autwHJM/xpWGo Qquv5yTQt9qbPi/v96YmLiQr5A2zOmy3YewuUxhFBmtIVQ3D3yLgRyVwhZRp9ulswuk2xHZOotY 8vNixfmMdBeDgW13sooAordeIO2RBETgLQnSdbNFDpQTCNrQ2XiUAtLxbT/LcHHg9RFE0NRmy+3 PySCGGLVxmb9xSMyhSXHojvmxQVqh X-Received: by 2002:a05:693c:6316:b0:33e:a0c3:4163 with SMTP id 5a478bee46e88-340034baf03mr4274190eec.24.1790321024465; Fri, 25 Sep 2026 00:23:44 -0700 (PDT) X-Received: by 2002:a05:693c:6316:b0:33e:a0c3:4163 with SMTP id 5a478bee46e88-340034baf03mr4274161eec.24.1790321023891; Fri, 25 Sep 2026 00:23:43 -0700 (PDT) Received: from [192.168.1.25] ([122.183.173.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3414485a9cdsm4378008eec.16.2026.09.25.00.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2026 00:23:43 -0700 (PDT) Message-ID: <84c8e0d7-b3f6-497d-93ac-4c3ad7e5956a@oss.qualcomm.com> Date: Fri, 25 Sep 2026 12:53:31 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/8] ASoC: qcom: lpass-va-macro: Add shikra compatible To: Mohammad Rafi Shaik , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , ajay.nandam@oss.qualcomm.com Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260922-add_shikra_support-v1-0-6c6cb6444caf@oss.qualcomm.com> <20260922-add_shikra_support-v1-4-6c6cb6444caf@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <20260922-add_shikra_support-v1-4-6c6cb6444caf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDAyOSBTYWx0ZWRfXzmGuarOgNCH3 09I98+yEGFpLhFoUgMEObsJp5C0nMGWELEAWcTa8NEahchM089SPV2Vh++12tBSnTmvujV7a41O nw4QPl9Gcq3UWT5UF8ku65fh2NKTn/A= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDAyOSBTYWx0ZWRfXwhFIMcC6K+uO MkvG0EK98urvwQByITpT3nt3efRSb/+iw6tfXmSUH/KMILZbk0LRKEjONBL+HNj09xKsSYo95QH Hb6ACbxyfHcnovfqOs0Q7iZ8FqHbewJfBYA86JuAEsCWV7Iev+ckPenm23sv0KDd+57jXIRUwZn hV398+DeZTM7wN2iKeiPwHx7p2jQUN7OTMN7gW/5XkgMm82qCQMp52JKrnGXJ80KSW8tKibFJfi kLLGaexy+Vvi2OD8ikxzAWYzgKifZXlbyr0lVWB3AA7JfmW5uE4cUrtrvrlTUV9SiRyzetvQ+PQ dRq6eRd2tE6eBW0FPN9MiI5IMYbXdkE9+3YwJ3eP/WLgAgYWZF/e8lsmqCUu+uStBZRuJOZ7TI/ 0mY0SJew/uig8gtJn60/2nH+IPhNaugALBAYHqcWWMnpajZbKBjA4EyEUkYGLR/vC8TpWQ1e40a cqJlLIpqzWfhdk+jiIg== X-Authority-Analysis: v=2.4 cv=VuO2kO2n c=1 sm=1 tr=0 ts=6ab62181 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=uk8ae9/F1LYL5lfeGCaUoA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=PkPm6FwxeQMnA0nEx70A:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: ZU_cfVC5wrFid47eDbT74z5XMwz-cs3h X-Proofpoint-ORIG-GUID: ZU_cfVC5wrFid47eDbT74z5XMwz-cs3h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250029 On 9/22/2026 3:12 PM, Mohammad Rafi Shaik wrote: > Add shikra specific VA macro data and register programming needed by > the LPASS codec v4.1 implementation. > > LPASS codec v4.1 extends the VA macro with four adaptive filter (ADPT) > blocks at 0x0800..0x09a4 and requires the FS counter to be bypassed > before it is enabled. > > Add the new registers as a separate reg_default array, used by a v4.1 > specific regmap config. > > The register layout has to be chosen before the regmap exists, i.e. > before CDC_VA_TOP_CSR_CORE_ID_* can be read, so it comes from match data; > probe then cross checks it against the version reported by the hardware. > > Signed-off-by: Mohammad Rafi Shaik > --- > sound/soc/codecs/lpass-va-macro.c | 281 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 274 insertions(+), 7 deletions(-) > > + > +static const struct va_macro_data shikra_va_data = { > + .has_swr_master = true, > + .has_npl_clk = true, > + .version = LPASS_CODEC_VERSION_4_1, > + .regmap_config = &va_4_1_regmap_config, > +}; > + The commit message says probe cross-checks the match-data-selected register layout against the hardware-reported codec version, but setting .version here means va_macro_probe() takes the data->version path and skips va_macro_set_lpass_codec_version(), so the hardware version is not read. Should this leave .version unset for Shikra, let va_macro_set_lpass_codec_version() read/validate the hardware version, and then compare the detected version against the selected regmap_config? Thanks Ajay Kumar Nandam