From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19ECC433EF for ; Mon, 4 Jul 2022 10:44:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbiGDKoP (ORCPT ); Mon, 4 Jul 2022 06:44:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbiGDKoM (ORCPT ); Mon, 4 Jul 2022 06:44:12 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B55152647; Mon, 4 Jul 2022 03:44:11 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 62B6766015A6; Mon, 4 Jul 2022 11:44:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656931450; bh=gjNEsUi0SsF/6vtg4n8Tc6Jg9gWEjEsUA2sD8bp3x9I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CioOKrpDBDzPBsG3sOxB6gSfHCwZY7y8rfYurcXucgtbNanLuZyEK65ugGX2LLs4V dFKRiesAMYgxiR47wQvDPJBuBmt3S/nD8IeQWXNnLvdnnYIFDESGu0b5o+6DQDSx22 lc0gNcxYvD+zaz+qQS4DA6vBz/s6u+i6BKT5KnWjHv8FTNh5sIDZffjdxdZqZV3j0d OddSGfq5JlDhU6UWuMb75zhx69WQbzMPSCSmLu8ArrCKdV0wU9SpI4aEjTSPTyxFkB soyVnShjmhFu8A+ArMUl7Akqabr6UYyPG2qQqN9FTNJkDlual7BTuzAmndoUYsWB7R IRmJE2yXMbbwA== Message-ID: <84ce9b03-9edd-9ef1-aec1-127b34c23021@collabora.com> Date: Mon, 4 Jul 2022 12:44:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 16/16] arm64: dts: mt8195: Add display node for vdosys0 Content-Language: en-US To: Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Jie Chen , Weiyi Lu Cc: iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, "Jason-JH.Lin" References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-17-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220704100028.19932-17-tinghan.shen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 04/07/22 12:00, Tinghan Shen ha scritto: > From: "Jason-JH.Lin" > > Add display node for vdosys0 of mt8195. > > Signed-off-by: Jason-JH.Lin > Signed-off-by: Tinghan Shen > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 109 +++++++++++++++++++++++ > 1 file changed, 109 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 724c6ca837b6..faea8ef33e5a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1961,6 +1961,7 @@ > vdosys0: syscon@1c01a000 { > compatible = "mediatek,mt8195-mmsys", "syscon"; > reg = <0 0x1c01a000 0 0x1000>; > + mboxes = <&gce0 0 CMDQ_THR_PRIO_4>; > #clock-cells = <1>; > }; > > @@ -1976,6 +1977,114 @@ > power-domains = <&spm MT8195_POWER_DOMAIN_VENC_CORE1>; > }; > > + ovl0: ovl@1c000000 { > + compatible = "mediatek,mt8195-disp-ovl", > + "mediatek,mt8183-disp-ovl"; This fits in one line, please fix, here and all of the other instances of that. > + reg = <0 0x1c000000 0 0x1000>; > + interrupts = ; > + power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > + clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>; > + iommus = <&iommu_vdo M4U_PORT_L0_DISP_OVL0_RDMA0>; > + mediatek,gce-client-reg = > + <&gce0 SUBSYS_1c00XXXX 0x0000 0x1000>; Same for gce-client-reg. Regards, Angelo