From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB33C433EF for ; Thu, 31 Mar 2022 20:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235453AbiCaUXS (ORCPT ); Thu, 31 Mar 2022 16:23:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234915AbiCaUXQ (ORCPT ); Thu, 31 Mar 2022 16:23:16 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61CAE241B5D for ; Thu, 31 Mar 2022 13:21:27 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id bq8so1591611ejb.10 for ; Thu, 31 Mar 2022 13:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ILnXUCualFGuYlaEUrjI+Jt4xkDksiZWcqq6tSgI9Zw=; b=ZW1CjLONxlLC58VYQbdnqzQGqdnzwh/8Jk3XX/BhEOsvEfvlBmszlJ6XyM5eEnPruf ZCS8+Ef8Fm7zTkrvkaUmsNd6yxjOHKT5fuo3aqu44qhaFhWNSf+NvGqvZSxcTwKRqAJt stYv5p90mRuHeOp9QCy1vKheAwT2tNH0T/7A49oA9r8ou4/MZhQRUAbba+aYebPwm3H1 LbMszmPMllWpW6qAwEni1zTUW9XoV2j3Tq5S61bi7W5yoTRzi5A6EiMa8Gvqfjk1+TH5 2f8UPKADYzfeRb/r8i3KIDWkZ1EIgq22lpKipKLiaRyn4LdTQtDXpiUwQjBvRvwhdYOC P8Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ILnXUCualFGuYlaEUrjI+Jt4xkDksiZWcqq6tSgI9Zw=; b=vornizjbMX7e20o6NjjCfQeHIUChCiwTxbgkoTIRvhY7OkB/Iu4dhwswMHGOPouE2E rhXlMMWb3en3Z/I1uO64RFTkT/F6AOpYE38kd/UQRLHneybuBh8LgF1TY3NANL1aCECr +9X5dNhawhlyWQvzqK+J56rIz9m4+QBrhmolib08h8UM0TrXkx95Udb0fFeD/73aq65S PkAqdQ+t68XzBdvEsBECYIIitLCZKE95D73kkSD6qDH/Bp9IUJSzm2LSKUHx+jmcYHxJ IqkHyBJefgfV99WmpSEvBwENWF9LZdGEVsHEQInY51iNVa2rVcdUYvgvtJhGlcn6ynI5 4qVg== X-Gm-Message-State: AOAM533QMb1tijoAkyBCsC31f2V/OMuiiEqpGyy0Y0wo22MQoTNnuNha sdw1HfT0aAXHayshLBV6tYItSg== X-Google-Smtp-Source: ABdhPJwThRh2Gmkgw1Udsp9CkVtNz9RvwQbVrpKMO/HzmZ5TUdL2hXfqZOSOSrdGFCizgq6F8zT8BA== X-Received: by 2002:a17:907:9705:b0:6e4:b769:286f with SMTP id jg5-20020a170907970500b006e4b769286fmr2781454ejc.728.1648758085933; Thu, 31 Mar 2022 13:21:25 -0700 (PDT) Received: from [192.168.0.168] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id ch26-20020a0564021bda00b00418f99695f0sm202380edb.23.2022.03.31.13.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 13:21:25 -0700 (PDT) Message-ID: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> Date: Thu, 31 Mar 2022 22:21:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Content-Language: en-US To: Qin Jian , krzysztof.kozlowski@canonical.com Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de, linux@armlinux.org.uk, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2022 10:29, Qin Jian wrote: > Add documentation to describe Sunplus SP7021 clock driver bindings. > > Signed-off-by: Qin Jian > --- > Move 'reg' after 'compatible' > --- > .../bindings/clock/sunplus,sp7021-clkc.yaml | 39 ++++++ > MAINTAINERS | 2 + > include/dt-bindings/clock/sp-sp7021.h | 112 ++++++++++++++++++ > 3 files changed, 153 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > create mode 100644 include/dt-bindings/clock/sp-sp7021.h > > diff --git a/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > new file mode 100644 > index 000000000..41e73a088 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/sunplus,sp7021-clkc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SP7021 SoC Clock Controller Binding > + > +maintainers: > + - Qin Jian > + > +properties: > + compatible: > + const: sunplus,sp7021-clkc > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + > + clkc: clock-controller@9c000000 { > + compatible = "sunplus,sp7021-clkc"; > + reg = <0x9c000000 0x280>; > + #clock-cells = <1>; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 26066f199..5d8b420d0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2744,8 +2744,10 @@ L: linux-arm-kernel@lists.infradead.org (moderated for mon-subscribers) > S: Maintained > W: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview > F: Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml > +F: Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml > F: Documentation/devicetree/bindings/reset/sunplus,reset.yaml > F: drivers/reset/reset-sunplus.c > +F: include/dt-bindings/clock/sp-sp7021.h > F: include/dt-bindings/reset/sp-sp7021.h > > ARM/Synaptics SoC support > diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h > new file mode 100644 > index 000000000..45dac6de8 > --- /dev/null > +++ b/include/dt-bindings/clock/sp-sp7021.h > @@ -0,0 +1,112 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) Sunplus Technology Co., Ltd. > + * All rights reserved. > + */ > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > + > +#define XTAL 27000000 > + > +/* plls */ > +#define PLL_A 0 > +#define PLL_E 1 > +#define PLL_E_2P5 2 > +#define PLL_E_25 3 > +#define PLL_E_112P5 4 > +#define PLL_F 5 > +#define PLL_TV 6 > +#define PLL_TV_A 7 > +#define PLL_SYS 8 > + > +/* gates: mo_clken0 ~ mo_clken9 */ > +#define CLK_SYSTEM 0x10 > +#define CLK_RTC 0x12 YAML looks ok, but here comment from Arnd also applies. These should be regular decimal numbers incremented by one. Best regards, Krzysztof