* [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property
@ 2023-07-12 23:59 David Heidelberg
2023-07-13 6:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: David Heidelberg @ 2023-07-12 23:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Wesley Cheng
Cc: David Heidelberg, linux-arm-msm, linux-usb, devicetree,
linux-kernel
The driver has support for it already. Only missing bit is dt-binding entry.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 4875c5b7d5b5..7099b583d21c 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -107,6 +107,10 @@ properties:
minItems: 1
maxItems: 4
+ extcon:
+ description:
+ Phandle to the extcon device providing the cable state.
+
qcom,select-utmi-as-pipe-clk:
description:
If present, disable USB3 pipe_clk requirement.
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property
2023-07-12 23:59 [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property David Heidelberg
@ 2023-07-13 6:37 ` Krzysztof Kozlowski
2023-07-14 3:20 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-13 6:37 UTC (permalink / raw)
To: David Heidelberg, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Wesley Cheng
Cc: linux-arm-msm, linux-usb, devicetree, linux-kernel
On 13/07/2023 01:59, David Heidelberg wrote:
> The driver has support for it already. Only missing bit is dt-binding entry.
No, because the child node already has it. We do not need to extcons for
one USB. Also another reason is that it should be deprecated.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property
2023-07-13 6:37 ` Krzysztof Kozlowski
@ 2023-07-14 3:20 ` Bjorn Andersson
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-07-14 3:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: David Heidelberg, Andy Gross, Konrad Dybcio, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Wesley Cheng, linux-arm-msm,
linux-usb, devicetree, linux-kernel
On Thu, Jul 13, 2023 at 08:37:55AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 01:59, David Heidelberg wrote:
> > The driver has support for it already. Only missing bit is dt-binding entry.
>
> No, because the child node already has it. We do not need to extcons for
> one USB. Also another reason is that it should be deprecated.
>
In the current design of the Linux dwc3 driver we actually need both
nodes to be extcon targets, as both device drivers needs to react to the
role change. So I think the patch accurately describes the intended
design of today.
That said, we do not want to do this for the Type-C case, where we use a
full port node. Combined with other reasons, we really should fix the
dwc3 driver model so that the core propagates the role changes to the
glue drivers, and as such I agree that we shouldn't pick this patch.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-14 3:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 23:59 [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property David Heidelberg
2023-07-13 6:37 ` Krzysztof Kozlowski
2023-07-14 3:20 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).