From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>,
pavel@ucw.cz, lee@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: leds: Add LED1202 LED Controller
Date: Sun, 27 Oct 2024 15:31:38 +0100 [thread overview]
Message-ID: <84dcf231-df5d-7503-f61c-10a30d092287@gmail.com> (raw)
In-Reply-To: <Zx0AqwUUchl4M6po@admins-Air>
Hi Vicentiu,
On 10/26/24 16:46, Vicentiu Galanopulo wrote:
> The LED1202 is a 12-channel low quiescent current LED driver with:
> * Supply range from 2.6 V to 5 V
> * 20 mA current capability per channel
> * 1.8 V compatible I2C control interface
> * 8-bit analog dimming individual control
> * 12-bit local PWM resolution
> * 8 programmable patterns
>
> If the led node is present in the controller then the channel is
> set to active.
>
> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>
> ---
>
> Changes in v3:
> - remove active property
> Changes in v2:
> - renamed label to remove color from it
> - add color property for each node
> - add function and function-enumerator property for each node
>
> .../devicetree/bindings/leds/st,led1202.yml | 103 ++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yml
>
> diff --git a/Documentation/devicetree/bindings/leds/st,led1202.yml b/Documentation/devicetree/bindings/leds/st,led1202.yml
> new file mode 100644
> index 000000000000..f64273599181
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/st,led1202.yml
> @@ -0,0 +1,103 @@
> +patternProperties:
> + "^led@[0-9a-f]+$":
> + type: object
> + $ref: common.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 0
> + maximum: 11
> +
> + required:
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@58 {
> + compatible = "st,led1202";
> + reg = <0x58>;
> + address-cells = <1>;
> + size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + label = "led1";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_RED>;
> + function-enumerator = <1>;
You should use devm_led_classdev_register_ext() to let LED core create
LED class device name basing on the above three properties.
'label' property will be useless in that case, so please drop it and
avoid constructing LED name in the driver.
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "led2";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_GREEN>;
> + function-enumerator = <2>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "led3";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_BLUE>;
> + function-enumerator = <3>;
> + };
> +
> + led@3 {
> + reg = <3>;
> + label = "led4";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_RED>;
> + function-enumerator = <4>;
> + };
> +
> + led@4 {
> + reg = <4>;
> + label = "led5";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_GREEN>;
> + function-enumerator = <5>;
> + };
> +
> + led@5 {
> + reg = <5>;
> + label = "led6";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_BLUE>;
> + function-enumerator = <6>;
> + };
> +
> + led@6 {
> + reg = <6>;
> + label = "led7";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_RED>;
> + function-enumerator = <7>;
> + };
> +
> + led@7 {
> + reg = <7>;
> + label = "led8";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_GREEN>;
> + function-enumerator = <8>;
> + };
> +
> + led@8 {
> + reg = <8>;
> + label = "led9";
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_BLUE>;
> + function-enumerator = <9>;
> + };
> + };
> + };
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2024-10-27 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 14:46 [PATCH v3 1/3] dt-bindings: leds: Add LED1202 LED Controller Vicentiu Galanopulo
2024-10-27 14:31 ` Jacek Anaszewski [this message]
2024-10-27 20:33 ` Krzysztof Kozlowski
2024-11-01 20:20 ` Vicentiu Galanopulo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84dcf231-df5d-7503-f61c-10a30d092287@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).