From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3704C433EF for ; Wed, 27 Apr 2022 18:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiD0TA2 (ORCPT ); Wed, 27 Apr 2022 15:00:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbiD0TAV (ORCPT ); Wed, 27 Apr 2022 15:00:21 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E2D57306C for ; Wed, 27 Apr 2022 11:45:55 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id t6so3738203wra.4 for ; Wed, 27 Apr 2022 11:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=f6A2106wpv8FyptFj0CXPhRPGyQFfkvsvlQQIXuralk=; b=USObKSJ2kUmKR31NngLz5pIhR33a1ZqcyGnNJvvYxbtjXLPQ7/hNFRSGycWBoFt1nc N59r9GCtKEmYZj+ib5amTDGDj14ILlYXGFtMVNvOyhmi5HMcGMWTx3wGdr9Kaa/Xd8Pv JFg5T4JrpfTKFMvZurcH4H0qA/oFeuochOGfzpSJEYbSxIlXdWL0a6Ht91kjt5uiL5Vm 9MRD1gGbh3/YwNuS3P35nfQ97q+CWsojhI5X/qzkWKSGTLr3Wotx67sIZmRB9kBuy9QQ ds6kBFj6Va/Tv0NYAzeJIwu+5RdbvIdSZZ7GeNN45cRktvWeQnnXVX1umxvn6He7Op+1 xCCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=f6A2106wpv8FyptFj0CXPhRPGyQFfkvsvlQQIXuralk=; b=6S2Df/JV1gCx3c12vug9MGsl6FNjfOTTGz5goPYnNzNeoRt5+nWezmOuy/yqVhW0GG G4jtSMVQWSq9SNe5Fa07m/us1SyUTLtHiNV1/ssHywlU7XKUCuMPYq2bCf14idDVyFO5 hWq89gM8azQDuN4tkHq2VwfpiBDMnnEXBbRUo+jsrHq7flyH5xO7+9+JnTDoa8vpeoT+ 3Cte4GF2S8zTzKhhqhBFKU0W3NTiZb13bKAxvXBWWNYorbk2kJFYoYjVW9+DdJf1HbQE iptxQ2HcovHIn42m9x2MwCdtPUGKGuUzYUHT7D6oeYbgpVG+ZRrsEHfLbasi6s3MlbR6 IN2w== X-Gm-Message-State: AOAM531iGGDUXzCRJUu/4flcv4olgrL2IM4SwCfnmYKxrOPlSkBuBSNa To/KsmVIUVTA2lST0AbGrV45lxhlt4imvg== X-Google-Smtp-Source: ABdhPJxx/6zywqLRr3upfT6X/fKMN9/MUALq+nXlNuxuHRehXy0gUkKXOtbbfTTNa2tlTpDBgcRNkA== X-Received: by 2002:a5d:47c4:0:b0:20a:e090:8590 with SMTP id o4-20020a5d47c4000000b0020ae0908590mr10237714wrc.465.1651085154133; Wed, 27 Apr 2022 11:45:54 -0700 (PDT) Received: from [192.168.0.33] (cpc78119-cwma10-2-0-cust590.7-3.cable.virginm.net. [81.96.50.79]) by smtp.gmail.com with ESMTPSA id n13-20020a5d51cd000000b0020af0706b9csm1774340wrv.53.2022.04.27.11.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 11:45:52 -0700 (PDT) Message-ID: <850d2c2d-9531-ed4c-48fc-2daa0311e3e6@linaro.org> Date: Wed, 27 Apr 2022 19:45:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v13 3/9] mfd: qcom-spmi-pmic: read fab id on supported PMICs Content-Language: en-US To: Lee Jones Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sumit.semwal@linaro.org, amit.pundir@linaro.org, Krzysztof Kozlowski , Dmitry Baryshkov References: <20220323162820.110806-1-caleb@connolly.tech> <20220323162820.110806-4-caleb@connolly.tech> <10f7cb8e-4c2a-0bba-df55-16b56d429147@linaro.org> From: Caleb Connolly In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/04/2022 19:24, Lee Jones wrote: > On Tue, 26 Apr 2022, Caleb Connolly wrote: >> On 25/04/2022 16:05, Lee Jones wrote: >>> On Wed, 23 Mar 2022, Caleb Connolly wrote: >>> >>>> From: Caleb Connolly >>>> >>>> The PMI8998 and PM660 expose the fab_id, this is needed by drivers like >>>> the RRADC to calibrate ADC values. >>>> >>>> Signed-off-by: Caleb Connolly >>>> Reviewed-by: Dmitry Baryshkov >>>> Tested-by: Dmitry Baryshkov >>>> --- >>>> drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ >>>> include/soc/qcom/qcom-spmi-pmic.h | 1 + >>>> 2 files changed, 8 insertions(+) >>> >>> Please change the Subject line to match the style of the sub-system? >> Hi, sorry if this is a silly question, I don't quite understand what you >> want me to change here, the subject line is in the same "mfd: driver:" >> format as other patches in the subsystem? > > mfd: qcom-spmi-pmic: Read fab ID on supported PMICs > > What's 'fab' should that be capitalised too? "fab" is short for fabrication I think, the register value can be used to determine which factory the chip was manufactured in. I can make it clearer and go for mfd: qcom-spmi-pmic: Read fabrication ID on supported PMICs > >>> Once changed: >>> >>> Acked-by: Lee Jones >>> >> > -- Kind Regards, Caleb (they/he)