From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F4FC433FE for ; Fri, 25 Feb 2022 13:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241359AbiBYNbQ (ORCPT ); Fri, 25 Feb 2022 08:31:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241370AbiBYNbP (ORCPT ); Fri, 25 Feb 2022 08:31:15 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A004F22A241 for ; Fri, 25 Feb 2022 05:30:41 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id l2-20020a7bc342000000b0037fa585de26so4965257wmj.1 for ; Fri, 25 Feb 2022 05:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=Iz/C4kfIg+QU3WpdVAdERt4dHyjlNNmL0wic5dOiAa2/KqYsxtSwe/Xosjkk2QmiZU 8ryyBpvt8iNhB254uJeBq90QEsX8cWGXS8YcWBMjUH2iWu/2UItIYU0qDGVKCdEObZo4 426WHxKm1HRvHqkWld/rVUJ4k43SvcEkPjifb6JeKZUzRmifV18ZJYgQTfQGC59Ewh/f 5kQQWOMynPpZOME2jygah+5n4SJ8rRBuRMf96P3q4s38/eob6pzdWzH4I1pbPxun86su PylozFcPJ87NWL7Stzbx/8tmSSJCD2qL49xvM7G77NOhRLt4UQEq8HqsPW0LUKlFLn/a v8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iCYug2uN0yJ0h5qzrzM0t/ZXG7y0pW69zdo3//wJ5Mc=; b=a+0NO96fNq5dzzPOa7GgfjKdzlxr4WuhNjQKXekTS5wBHUqjRn9aB7gqcGRcqFDXTX GVAM4crjq+OqpxBsFTiTi9VyrDxxTKFeiQm2kYvqR0ltmwqGvydXO/LP7vsSZ0ciHA4x oHbzAvmeUjVyvqc/1/a92GlQJX4+pvPrIxChJeyxOIwhC65Q3tNXr6Vnb6UH9ho/EXse yuAlRCMz/2Duq69efpNbz2kskX4OqM15lm5S9wWwU0Aj+JLv+y3n6qDOLGuJBlKI2XXb 8flRE12JbufuEtioq5EbYj8k82VrHnjBLncWKvKzty6ts1MmZvAHDDIt5uCY3s8LjKoc PCxg== X-Gm-Message-State: AOAM532w9g8t/qy046qlPiuk7qD6zxq4eTbzoNK5E6Q+FHMPPNcLNjFG QzQ3hb0cELHdfC7/CoszFuJlYugF3Z2lfw== X-Google-Smtp-Source: ABdhPJxNOwK0M2yG7dyNvpA4W4t769Dz57u4tDUZ5Yawlwr+ZqoHjyWnaBVu9T+EYcXrNna7M8ECuA== X-Received: by 2002:a05:600c:211a:b0:380:d7b5:6e3a with SMTP id u26-20020a05600c211a00b00380d7b56e3amr2732823wml.125.1645795839794; Fri, 25 Feb 2022 05:30:39 -0800 (PST) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id a8-20020a056000100800b001e30ef6f9basm3305843wrx.18.2022.02.25.05.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 05:30:39 -0800 (PST) Message-ID: <852e35f6-ec8b-ddc6-f81f-f666e899b543@linaro.org> Date: Fri, 25 Feb 2022 13:30:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring Cc: Krzysztof Kozlowski , Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20220124160300.25131-1-zajec5@gmail.com> <20220218070729.3256-1-zajec5@gmail.com> <20220218070729.3256-3-zajec5@gmail.com> From: Srinivas Kandagatla In-Reply-To: <20220218070729.3256-3-zajec5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/02/2022 07:07, Rafał Miłecki wrote: > From: Rafał Miłecki > > NVRAM doesn't have cells at hardcoded addresses. They are stored in > internal struct (custom & dynamic format). It's still important to > define relevant cells in DT so NVMEM consumers can reference them. > > Update binding to allow including basic cells as NVMEM device subnodes. > > Signed-off-by: Rafał Miłecki Applied thanks, --srini > --- > V2: Add children nodes description per Rob's request > V3: Document NVMEM cells as properties > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 8c3f0cd22821..25033de3ef6b 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -14,6 +14,8 @@ description: | > NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9 > devices usiong I/O mapped memory. > > + NVRAM variables can be defined as NVMEM device subnodes. > + > maintainers: > - Rafał Miłecki > > @@ -27,11 +29,30 @@ properties: > reg: > maxItems: 1 > > + board_id: > + type: object > + description: Board identification name > + > + et0macaddr: > + type: object > + description: First Ethernet interface's MAC address > + > + et1macaddr: > + type: object > + description: Second Ethernet interface's MAC address > + > + et2macaddr: > + type: object > + description: Third Ethernet interface's MAC address > + > unevaluatedProperties: false > > examples: > - | > nvram@1eff0000 { > - compatible = "brcm,nvram"; > - reg = <0x1eff0000 0x10000>; > + compatible = "brcm,nvram"; > + reg = <0x1eff0000 0x10000>; > + > + mac: et0macaddr { > + }; > };