From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0DFA7A735; Sat, 17 Feb 2024 15:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708183840; cv=none; b=YrzFlF0ShscfGVPSp/4MrB0QIGug+0Y0e+j3+20L9Ljzm34xkHG3chGlp5mIjHhu15WJY26YX1jnHaV7dw86WXNsqaYnKHKO/Nic4Nt5DDooqSgJqOIO4tq2ojNVP4DpGoRvGNhf6/sdyKj/KZ4iBDEe4aqS6ETz9cMNBy6uZN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708183840; c=relaxed/simple; bh=xWFXeLRYbXI1C7vjCdpGuFnAyI509AAFl9bEpkjVRHs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iGoDppaoqYAVxKtnWJTeZmAhDB7QpZQUZLw318O7hK1S7q5FVFMt5Uy7835xgKdrTOS2tem/vTM1f2GVpSM65H5anRTi/nT50losNDrglVskz9vt1lOxI6LVujEgRm216anygRdNyJsjN7E1b/KKWP+IN9nd3coyEvKqPeRO9DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9rtdNYd; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9rtdNYd" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e10e50179bso2156164b3a.1; Sat, 17 Feb 2024 07:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708183838; x=1708788638; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=/v4hnO8ad2NTkb2Hz0EjoGr665rx76mpWxWfADMMFXc=; b=Z9rtdNYdzU6oENK1R+ft6/JSZWV95S+0T2c7PlLlm6lOxVIgOOTANVNep3mMVeMYYb +AtzRWTyVdc+KDnyeSRBCP4xolCtUOZzExvrOuBYoh+ldXqMECClXIyQhRzncbkIueTB Bb+Y1ysXZg50la17/g/mnrWj0gbqsB/t7XHu+D3VZSL306PgVKchk0Zh4i/rLNMf0+Ic GxfPHsZSJ/OsrOU6DGxHNkgiRgTiJNh5yyjNO/wR8jfa80ncQPsd9fE/zAFch5buxtuq RgAMT+ZdFDjZRYF9DcGDRml6dMdXfHsz9iQDT4piivC5bLhVU9ITbbHGAkBzce/ZWvqw 11mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708183838; x=1708788638; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/v4hnO8ad2NTkb2Hz0EjoGr665rx76mpWxWfADMMFXc=; b=eSqAcprZqOgdsV57hRnkZPig3eCbqfNhAkeB5FqCLrcR9GNYXb7pdAHqQsLRuw9klg E0ax2GWGd+m2H/O38JiMZYSgh4oj8J0xK22jpUNlulWUlK52+ZElOIrGWv7cSiuXSEJM dsQqJtzc2zkBmB76zpyxTQHx86cp3w3wqGCdiaNOhwSkEpjgH/d58NNg6jyFJQ0ViXq0 1bbHskimWGEospDwAuyaLOe5p4HvW3I10Waza/uvCxWmtcuI83OlJytYXwUBtGW8FmDR 6A8/DdXQTDXXJtR7z2CMsTmTAU3NSCImNJRG530Fb1nu+ZT1PD0kIsrWDQ7h+l7vxlx6 65Kg== X-Forwarded-Encrypted: i=1; AJvYcCWLrDEISOFfQ+jX+upCup4515CFEiBWxNIDgokC2awmxikKc2L9a+4i75vIR0lBokupQxBc1B0mx8XEP4LPcTwGIoiRP1TZxkDFGV88eGk1HuqLVKZ/w6ntHCNy28+gTwfowpE8GsnmTQ== X-Gm-Message-State: AOJu0Yypuck8jvHjQ025EErNJdgIDxp4bhXmYZ+1A25ch8EBjQ/gMBwC 0o+Y9SYX1kZqayccf6F3C+QeW5kvtqcA2WIKiE+d4N/Zi8dHTMO+CCqDKsLv X-Google-Smtp-Source: AGHT+IH69XRACphPV7/6YbHJMq/zbVdKzN3Qjd8Ys3Bh0mYdDKo86CXpSRI95dEZ7waIlg7J8+odIA== X-Received: by 2002:a05:6a00:4bb5:b0:6e0:39eb:4458 with SMTP id kt21-20020a056a004bb500b006e039eb4458mr7718253pfb.13.1708183837840; Sat, 17 Feb 2024 07:30:37 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id o23-20020a056a001b5700b006e14626ee94sm1781778pfv.155.2024.02.17.07.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 07:30:37 -0800 (PST) Sender: Guenter Roeck Message-ID: <85307d34-bb60-41ea-b478-c821dbd2b51b@roeck-us.net> Date: Sat, 17 Feb 2024 07:30:35 -0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: hwmon: add common properties with label Content-Language: en-US To: Krzysztof Kozlowski , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20240216-dt-bindings-hwmon-common-v1-0-3c2c24ff1260@linaro.org> <20240216-dt-bindings-hwmon-common-v1-1-3c2c24ff1260@linaro.org> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/17/24 00:21, Krzysztof Kozlowski wrote: > On 16/02/2024 18:11, Guenter Roeck wrote: >> On 2/15/24 23:55, Krzysztof Kozlowski wrote: >>> Linux hwmon core code parses "label" property for each device, so add a >>> common schema for that. >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> From hwmon perspective: >> >> Acked-by: Guenter Roeck >> >>> --- >>> .../devicetree/bindings/hwmon/hwmon-common.yaml | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml >>> new file mode 100644 >>> index 000000000000..d83f4180f622 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml >>> @@ -0,0 +1,16 @@ >>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/hwmon/hwmon-common.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Hardware Monitoring Devices Common Properties >>> + >>> +maintainers: >>> + - Guenter Roeck >>> + >>> +properties: >>> + label: >>> + description: A descriptive name for this device. >>> + >> >> Would it make sense to also add shunt-resistor-micro-ohms ? > > It's not present on many devices, I think, so it is also not parsed by > hwmon core. I plan to add above $ref to hwmon-common to each hwmon > binding, so this would mean all of them will get shunt-resistor. I would > not add it, but I also don't mind if I am overruled. > No problem, I just don't know how such common rules are supposed to be understood. Thanks a lot for the clarification. Thanks, Guenter