From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
devicetree@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
lvjianmin@loongson.cn, WANG Xuerui <git@xen0n.name>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for reg-names
Date: Thu, 7 Dec 2023 09:24:40 +0100 [thread overview]
Message-ID: <857491d6-6360-4ed2-b38c-0477b75b19f7@linaro.org> (raw)
In-Reply-To: <0c1211e5-95a0-4caf-bc59-4a453fcf011a@linaro.org>
On 07/12/2023 09:23, Krzysztof Kozlowski wrote:
> On 07/12/2023 08:29, Binbin Zhou wrote:
>> As we know, the Loongson-2K0500 is a single-core CPU, and the
>> core1-related register (isr1) does not exist. So "reg" and "reg-names"
>> should be set to "minItems 2"(main nad isr0).
>>
>> This fixes dtbs_check warning:
>>
>> DTC_CHK arch/loongarch/boot/dts/loongson-2k0500-ref.dtb
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg-names: ['main', 'isr0'] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: Unevaluated properties are not allowed ('reg-names' was unexpected)
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11400: reg: [[0, 534844416, 0, 64], [0, 534843456, 0, 8]] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>> arch/loongarch/boot/dts/loongson-2k0500-ref.dtb: interrupt-controller@1fe11440: reg-names: ['main', 'isr0'] is too short
>> From schema: Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml
>>
>> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
>> Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>
> Where? Point me to exact email on lore.
>
Ah, I see at v4, it's ok:
https://lore.kernel.org/all/170015648721.2522214.13442341316883618917.robh@kernel.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-07 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:29 [PATCH v6 0/2] dt-bindings: interrupt-controller: Fix some loongson,liointc warnings Binbin Zhou
2023-12-07 7:29 ` [PATCH v6 1/2] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for reg-names Binbin Zhou
2023-12-07 8:23 ` Krzysztof Kozlowski
2023-12-07 8:24 ` Krzysztof Kozlowski [this message]
2023-12-07 7:29 ` [PATCH v6 2/2] dt-bindings: interrupt-controller: loongson,liointc: Fix dtbs_check warning for interrupt-names Binbin Zhou
2023-12-29 15:08 ` [PATCH v6 0/2] dt-bindings: interrupt-controller: Fix some loongson,liointc warnings Huacai Chen
2024-01-09 9:56 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857491d6-6360-4ed2-b38c-0477b75b19f7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xen0n.name \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).