From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506AFC00A89 for ; Mon, 2 Nov 2020 20:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 143BA22268 for ; Mon, 2 Nov 2020 20:00:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Met36lmB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726031AbgKBUAi (ORCPT ); Mon, 2 Nov 2020 15:00:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbgKBUAg (ORCPT ); Mon, 2 Nov 2020 15:00:36 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F507C0617A6; Mon, 2 Nov 2020 12:00:36 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id v6so18969671lfa.13; Mon, 02 Nov 2020 12:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fmGeQz4Og6FDipaMU7MfHyA+Ho1Q2EbyeVQm7OOUMbk=; b=Met36lmBPZbI3Bg/Pi0BDLI/08hKmflwudKsCksniYRSnC2W/wiUPktXMcCMYINb+O rnW3KpYgGqt6fxwfqGSoOmb4XiPe3VezWY7KCiemXYzWkwNgSEGpOgUogVpm09EeZivV xIgQ/72kcfGJSipTedh4kjJc48ivxagpm/moGDHqHS/jm2iNCk4KY/KZ7aWfTGumeg7n CwFwoVUuEoXAZz1cgjbeIJAtWqlAxKUci6wnx2w/PRfbQWjp6xzpnK+i5K8n1hdDrO1z +nnfSO1vJ9GcSOU8KxsEicROpjhfr3ZgX6xqqRr7xqWzgo4/xB1cn7CdgvRcWL96lURq PUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fmGeQz4Og6FDipaMU7MfHyA+Ho1Q2EbyeVQm7OOUMbk=; b=e9P1j1W3qot0kvdkeodpjHikzRG5QdhzjrVtWCKXLTpcLgYnwqG/P1WyfubQOs1iNZ r2/pbTiPTmo3BiVupunRi9dP+wP3A0zCujDxxxx5hqOdinzjDkW5hfN9QiYDyLTEWwj6 JcxjpphlHs0Z9s84UtNT6acKdJj2iyDfm1p9Z0zABlVa37PmGqFfeJc9neouypUIUs53 FLehNou3RJ3sUf6OIEIjshJG8981HPH5j0XxyisdmG8GbtBt9/MPtg8K+B0JtiVf+9Ca Rlfj6e6jbXWHPCbm46weSuHvSOjK2h0PVj6MVdFiY9R6g9ZMaKb2CCk1fbYc7wmnDBTh 942w== X-Gm-Message-State: AOAM531GcGvcX63r0sRgFNjhItEitGNfxi1+UUEXCqHAmWqF6tPFzXiR igG8761V73fFfViT7H+9tTbqEY0UjBs= X-Google-Smtp-Source: ABdhPJzGAN9ixbmRmzZSK6h8lOS09fz7Yt/jWFfwFXsjxUpkLxmWqAQ38fK9Cv8CucOCcjXzDPd2iw== X-Received: by 2002:a19:5f5c:: with SMTP id a28mr6131558lfj.434.1604347234537; Mon, 02 Nov 2020 12:00:34 -0800 (PST) Received: from [192.168.2.145] (109-252-193-177.dynamic.spd-mgts.ru. [109.252.193.177]) by smtp.googlemail.com with ESMTPSA id h26sm2932372ljl.55.2020.11.02.12.00.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2020 12:00:33 -0800 (PST) Subject: Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree To: cwchoi00@gmail.com Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, Linux PM list , linux-kernel , dri-devel , devicetree References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-52-digetx@gmail.com> <2ebd184c-60e8-19e2-9965-19481ced1c70@gmail.com> From: Dmitry Osipenko Message-ID: <85772f5b-1b3d-5bff-7b2e-5b00b83c8a20@gmail.com> Date: Mon, 2 Nov 2020 23:00:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 01.11.2020 18:44, Chanwoo Choi пишет: >>> I recommend that you use dev_pm_opp_of_get_opp_desc_node(&pdev->dev) >>> to check whether a device contains opp-table or not. >> I'm not sure what are the benefits, this will make code less >> expressive/readable and we will need to add extra of_node_put(), which >> device_property_present() handles for us. >> >> Could you please give the rationale? > IMO, 'operating-points-v2' word was defined on OPP core. I think that > the external user > of OPP better to use the public helper function instead of using the > interval definition > or value of OPP core directly. Basically, I prefer the provided helper > function if there. > But, it is not critical and doesn't affect the operation. If you want > to keep, it is ok. > I'll prefer to keep it since it's better for the readability of the code, thanks.