From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E926C433EF for ; Tue, 26 Apr 2022 07:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343729AbiDZHL2 (ORCPT ); Tue, 26 Apr 2022 03:11:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343723AbiDZHLY (ORCPT ); Tue, 26 Apr 2022 03:11:24 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0380237BC7 for ; Tue, 26 Apr 2022 00:08:17 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id r13so34146561ejd.5 for ; Tue, 26 Apr 2022 00:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=myMJmmFzXabm0MK8zN+AefUrpxOTRg0KpTHnfY8SV+k=; b=dky4F+ZpEvfdqcQOTGzp4A+aq5RvLb28otRcNi3DcgkiqiFA2nKPK/Y9UDrHakFyMj fUlE7g537+mnO5GDaDHPiSjZVRCfCv02qJBG0mu8swW5UCNIXVIWvAMqpOoEvwaiaK/E MOvmPKiAr5XCwpx0dMWqecvTvO5NozzKjYbVyoDirTAPzUzU5abZrnwPwajnoCh+8hO7 UTUaucOUhwjTvWpxhezi+x4agKcerorZDZ5pFKuMUZmk9jYL9oURCNjOvQzcBZpZiCa/ nDeSBEfZuujw3mebo3w5NOy+Pi1Wu5Pe230s1dJg4M/4tC2/3/Da/wMa4hwMKxger2ps DQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=myMJmmFzXabm0MK8zN+AefUrpxOTRg0KpTHnfY8SV+k=; b=R9bqo3P0k2iDyaLceIJY73/GzXhzvX38MQhk2j3VSqIjKKS+0Cn67D1514RVL/17OL o1RMhClY2nDY22Ok8Dq5dueP2bMcZP1L19NteRGugASRdOQTce6TNNZfjGf5GrL6F5c6 ptPhnb2kHgEhQZZ5NOa8gd/Nkj9AualuyM+hdRfV6wtxL0jbtE2EWdzvSS32Tifx41Uq kmjjQ6joBJT0vlRwiaAtZV6JfmlEnnOrPhbi0h45rQyF27HcNIBiKXtUJFfBeMq56wpS Jb1YaFKykdiAvxFsH4V7Y8FFoQuHOuN5UhjF06HxncbXTQv7Mwml4B0cCj/uS+LVtv/3 LBxg== X-Gm-Message-State: AOAM530BxUNgwXoYyGzV4OwZw87MaDshfSUiYB8MYg6d7HF/MOoOCFVG kA6j7k40hPVnth2yaoT79gBu7g== X-Google-Smtp-Source: ABdhPJyJm7edS3wk4FQaxMVtJqIYWKgMPmgVMD3GlzTqVk274oieHiuG28hXKbIevNFawdYIy0Kihw== X-Received: by 2002:a17:906:5d0d:b0:6f3:a870:ff2a with SMTP id g13-20020a1709065d0d00b006f3a870ff2amr3803917ejt.171.1650956895542; Tue, 26 Apr 2022 00:08:15 -0700 (PDT) Received: from [192.168.0.244] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id p12-20020a50c94c000000b00425c48132bfsm5005280edh.55.2022.04.26.00.08.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 00:08:15 -0700 (PDT) Message-ID: <8579a3df-1a1d-c258-f65e-531cf0731949@linaro.org> Date: Tue, 26 Apr 2022 09:08:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 3/3] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Amit Kucheria , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20220425212750.2749135-1-dmitry.baryshkov@linaro.org> <20220425212750.2749135-4-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220425212750.2749135-4-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/04/2022 23:27, Dmitry Baryshkov wrote: > Split tsens properties to the child node of the gcc. This follows the > lead of ipq8064 (which also uses a separate node for tsens) and makes > device tree closer to other platforms, where tsens is a completely > separate device. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/clock/qcom,gcc-apq8064.yaml | 45 +++++++------------ > 1 file changed, 17 insertions(+), 28 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > index b867da12761e..f2762599f679 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > @@ -23,47 +23,36 @@ description: | > > properties: > compatible: > - enum: > - - qcom,gcc-apq8064 > - - qcom,gcc-msm8060 Hm, such list does not exist in mainline, so is your set rebased on something? See also: https://lore.kernel.org/linux-devicetree/20220425133527.3723233-1-robh@kernel.org/ https://lore.kernel.org/linux-devicetree/20220426064241.6379-1-krzysztof.kozlowski@linaro.org/ > - > - nvmem-cells: > - minItems: 1 > - maxItems: 2 > - description: > - Qualcomm TSENS (thermal sensor device) on some devices can > - be part of GCC and hence the TSENS properties can also be part > - of the GCC/clock-controller node. > - For more details on the TSENS properties please refer > - Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > - > - nvmem-cell-names: > - minItems: 1 > items: > - - const: calib > - - const: calib_backup I see the removal of tsens properties, but I do not see the other part of split - adding them as child. It does not come from qcom,gcc.yaml, either. > - > - '#thermal-sensor-cells': > - const: 1 > + - enum: > + - qcom,gcc-apq8064 > + - qcom,gcc-msm8060 > + - const: syscon > > required: > - compatible > - - nvmem-cells > - - nvmem-cell-names > - - '#thermal-sensor-cells' > > unevaluatedProperties: false > > examples: > - | > clock-controller@900000 { > - compatible = "qcom,gcc-apq8064"; > + compatible = "qcom,gcc-apq8064", "syscon"; > reg = <0x00900000 0x4000>; > - nvmem-cells = <&tsens_calib>, <&tsens_backup>; > - nvmem-cell-names = "calib", "calib_backup"; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>; > - #thermal-sensor-cells = <1>; > + > + thermal-sensor { > + compatible = "qcom,msm8960-tsens"; > + > + nvmem-cells = <&tsens_calib>, <&tsens_backup>; > + nvmem-cell-names = "calib", "calib_backup"; > + interrupts = <0 178 4>; 0 and 4 look like GIC/interrupt flags, so please use defines. > + interrupt-names = "uplow"; > + > + #qcom,sensors = <11>; > + #thermal-sensor-cells = <1>; > + }; Indentation looks weird here. > }; > ... Best regards, Krzysztof