From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A24FC433F5 for ; Sat, 2 Apr 2022 11:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239473AbiDBLkj (ORCPT ); Sat, 2 Apr 2022 07:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235038AbiDBLkh (ORCPT ); Sat, 2 Apr 2022 07:40:37 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6C2B13F15 for ; Sat, 2 Apr 2022 04:38:43 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id d29so1565273wra.10 for ; Sat, 02 Apr 2022 04:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8FFVolbjt7YQtgOwSMGhmxxnSOZEEydEW3XCqGYcvHI=; b=e6+pufWUWXMYXP2ayV2VVAJMz1VRBg6uRkjboRcQIz+HUhpny5gKBWS1u6h0hBubf6 VQRvvmEasxGHwA4YloPoMW1pOXmn+nVScFSVI8SGHv2gx5rFxGiZqX6yhbQ7F9R3/HKj /d4BW7h6PYY8/H8zZeOlymb/0qLB2u0RneOkDDMU/6P0Gj2cF5hsKeullDmLlaRCksLQ LR7YlWQd6Cx87wlBCcnaIyDtweohWF8yoeSKH6hdNZKTNl80BTslil2CpCgOWob1DxRP ZkVZbN+0QTuWX9yg/SlBSTufRF6GYF3bFmA6axIrYq30xIbcG12alnNXz6Z2MI74Xf2Z R8SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8FFVolbjt7YQtgOwSMGhmxxnSOZEEydEW3XCqGYcvHI=; b=qUXdiXRxC0xHdSFB7RVyjS49MnO8XzLp3jPDkW0EUn93rzUq/mX2itipJA7MvD3Row 1SXQGe86jAWbpLvHHbIf44WAP1x4seIx716wUlKqs/8NV7+V/32yqX925Jjl5drY8EdF Hu6KzfpTQ/YOQY1hWPnKjdxARw1FKWtsGp2LX1KuIk4sE236tCuUyph46jwzovOWsoV2 Di0VxOgCOCyyFWTf2iACRMpRFXgjV0Iok8/BXeXti9UQ5YHrxix6rJggHclQt1Icg0eA uxL/cCNYXg96oIqGpKy+KkicHhqJ8d4hyCEc83HRp9TQ2CKfd4GOCU1odzi/YkKUuS6l 9vHg== X-Gm-Message-State: AOAM533tSm6xBd+dXT+Cvs11CV963cqsAHKCeP/Q6aOaoM8zF/ded+RZ jtBfDlzIcpr6d8tGKPVEub3zNg== X-Google-Smtp-Source: ABdhPJzieEb8o87Ny7opSK6xjHHmcl1p7dLVnehn/hiuzdAE+8zJ43hgHIA62CpYaa+w0Zmx73s6Kw== X-Received: by 2002:adf:ee87:0:b0:203:de0b:b236 with SMTP id b7-20020adfee87000000b00203de0bb236mr10658770wro.337.1648899522201; Sat, 02 Apr 2022 04:38:42 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id y13-20020adffa4d000000b00203e3ca2701sm5909866wrr.45.2022.04.02.04.38.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 04:38:41 -0700 (PDT) Message-ID: <8588a941-6d3e-9e14-cb21-d7af29b4b2bd@linaro.org> Date: Sat, 2 Apr 2022 13:38:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] dt-bindings: mfd: syscon: Add support for regmap fast-io Content-Language: en-US To: AngeloGioacchino Del Regno , lee.jones@linaro.org Cc: robh+dt@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, kernel@collabora.com References: <20220401135048.23245-1-angelogioacchino.delregno@collabora.com> <20220401135048.23245-3-angelogioacchino.delregno@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220401135048.23245-3-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/04/2022 15:50, AngeloGioacchino Del Regno wrote: > The syscon driver now enables the .fast_io regmap configuration when > the 'fast-io' property is found in a syscon node. > > Keeping in mind that, in regmap, fast_io is checked only if we are > not using hardware spinlocks, allow the fast-io property only if > there is no hwlocks reference (and vice-versa). I have doubts you need a property for this. "fast" is subjective in terms of hardware, so this looks more like a software property, not hardware. I think most of MMIOs inside a SoC are considered fast. Usually also the syscon/regmap consumer knows which regmap it gets, so knows that it is fast or not. > > Signed-off-by: AngeloGioacchino Del Regno > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 13baa452cc9d..85a2e83b5861 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -83,11 +83,26 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [1, 2, 4, 8] > > + fast-io: > + description: > + Indicates that this bus has a very fast IO, for which > + acquiring a mutex would be significant overhead. > + When present, regmap will use a spinlock instead. Regmap is current implementation behind this, but it's not related to hardware, so how about removing it from the description? Something like: "..., for which different locking methods should be used to reduce overhead (e.g. spinlock instead of mutex)." > + type: boolean > + > hwlocks: > maxItems: 1 > description: > Reference to a phandle of a hardware spinlock provider node. > > +if: > + required: > + - hwlocks > +then: > + not: > + required: > + - fast-io > + > required: > - compatible > - reg Best regards, Krzysztof