* [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 [not found] <20250730082725.183133-1-daniel.lezcano@linaro.org> @ 2025-07-30 8:27 ` Daniel Lezcano 2025-07-30 23:36 ` Rob Herring 0 siblings, 1 reply; 5+ messages in thread From: Daniel Lezcano @ 2025-07-30 8:27 UTC (permalink / raw) To: daniel.lezcano, tglx Cc: S32, linux-kernel, ghennadi.procopciuc, Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS The Vybrid Family is a NXP (formerly Freescale) platform having a Programmable Interrupt Timer (PIT). This timer is an IP found also on the NXP Automotive platform S32G2 and S32G3. Add the compatible for those platforms to describe the timer. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- .../devicetree/bindings/timer/fsl,vf610-pit.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml index bee2c35bd0e2..2aac63a58bfd 100644 --- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml +++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml @@ -15,8 +15,12 @@ description: properties: compatible: - enum: - - fsl,vf610-pit + oneOf: + - const: fsl,vf610-pit + - const: nxp,s32g2-pit + - items: + - const: nxp,s32g3-pit + - const: nxp,s32g2-pit reg: maxItems: 1 -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 2025-07-30 8:27 ` [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 Daniel Lezcano @ 2025-07-30 23:36 ` Rob Herring 2025-07-31 7:41 ` Daniel Lezcano 0 siblings, 1 reply; 5+ messages in thread From: Rob Herring @ 2025-07-30 23:36 UTC (permalink / raw) To: Daniel Lezcano Cc: tglx, S32, linux-kernel, ghennadi.procopciuc, Krzysztof Kozlowski, Conor Dooley, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On Wed, Jul 30, 2025 at 10:27:21AM +0200, Daniel Lezcano wrote: > The Vybrid Family is a NXP (formerly Freescale) platform having a > Programmable Interrupt Timer (PIT). This timer is an IP found also on > the NXP Automotive platform S32G2 and S32G3. > > Add the compatible for those platforms to describe the timer. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > .../devicetree/bindings/timer/fsl,vf610-pit.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml > index bee2c35bd0e2..2aac63a58bfd 100644 > --- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml > +++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml > @@ -15,8 +15,12 @@ description: > > properties: > compatible: > - enum: > - - fsl,vf610-pit > + oneOf: > + - const: fsl,vf610-pit > + - const: nxp,s32g2-pit These 2 can be a single enum. Otherwise, Acked-by: Rob Herring (Arm) <robh@kernel.org> > + - items: > + - const: nxp,s32g3-pit > + - const: nxp,s32g2-pit > > reg: > maxItems: 1 > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 2025-07-30 23:36 ` Rob Herring @ 2025-07-31 7:41 ` Daniel Lezcano 2025-07-31 7:50 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Daniel Lezcano @ 2025-07-31 7:41 UTC (permalink / raw) To: Rob Herring Cc: tglx, S32, linux-kernel, ghennadi.procopciuc, Krzysztof Kozlowski, Conor Dooley, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Hi Rob, On 31/07/2025 01:36, Rob Herring wrote: > On Wed, Jul 30, 2025 at 10:27:21AM +0200, Daniel Lezcano wrote: >> The Vybrid Family is a NXP (formerly Freescale) platform having a >> Programmable Interrupt Timer (PIT). This timer is an IP found also on >> the NXP Automotive platform S32G2 and S32G3. >> >> Add the compatible for those platforms to describe the timer. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> .../devicetree/bindings/timer/fsl,vf610-pit.yaml | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >> index bee2c35bd0e2..2aac63a58bfd 100644 >> --- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >> +++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >> @@ -15,8 +15,12 @@ description: >> >> properties: >> compatible: >> - enum: >> - - fsl,vf610-pit >> + oneOf: >> + - const: fsl,vf610-pit >> + - const: nxp,s32g2-pit > > These 2 can be a single enum. Otherwise, Do you mean this ? enum: - fsl,vf610-pit - nxp,s32g2-pit > Acked-by: Rob Herring (Arm) <robh@kernel.org> Thanks for the review >> + - items: >> + - const: nxp,s32g3-pit >> + - const: nxp,s32g2-pit >> >> reg: >> maxItems: 1 >> -- >> 2.43.0 >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 2025-07-31 7:41 ` Daniel Lezcano @ 2025-07-31 7:50 ` Krzysztof Kozlowski 2025-07-31 8:24 ` Daniel Lezcano 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2025-07-31 7:50 UTC (permalink / raw) To: Daniel Lezcano, Rob Herring Cc: tglx, S32, linux-kernel, ghennadi.procopciuc, Krzysztof Kozlowski, Conor Dooley, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 31/07/2025 09:41, Daniel Lezcano wrote: > > Hi Rob, > > On 31/07/2025 01:36, Rob Herring wrote: >> On Wed, Jul 30, 2025 at 10:27:21AM +0200, Daniel Lezcano wrote: >>> The Vybrid Family is a NXP (formerly Freescale) platform having a >>> Programmable Interrupt Timer (PIT). This timer is an IP found also on >>> the NXP Automotive platform S32G2 and S32G3. >>> >>> Add the compatible for those platforms to describe the timer. >>> >>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>> --- >>> .../devicetree/bindings/timer/fsl,vf610-pit.yaml | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>> index bee2c35bd0e2..2aac63a58bfd 100644 >>> --- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>> +++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>> @@ -15,8 +15,12 @@ description: >>> >>> properties: >>> compatible: >>> - enum: >>> - - fsl,vf610-pit >>> + oneOf: >>> + - const: fsl,vf610-pit >>> + - const: nxp,s32g2-pit >> >> These 2 can be a single enum. Otherwise, > > Do you mean this ? > > enum: > - fsl,vf610-pit > - nxp,s32g2-pit > Yes. And also please correct the subject prefix to match subsystem, git log --oneline or: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 2025-07-31 7:50 ` Krzysztof Kozlowski @ 2025-07-31 8:24 ` Daniel Lezcano 0 siblings, 0 replies; 5+ messages in thread From: Daniel Lezcano @ 2025-07-31 8:24 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring Cc: tglx, S32, linux-kernel, ghennadi.procopciuc, Krzysztof Kozlowski, Conor Dooley, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 31/07/2025 09:50, Krzysztof Kozlowski wrote: > On 31/07/2025 09:41, Daniel Lezcano wrote: >> >> Hi Rob, >> >> On 31/07/2025 01:36, Rob Herring wrote: >>> On Wed, Jul 30, 2025 at 10:27:21AM +0200, Daniel Lezcano wrote: >>>> The Vybrid Family is a NXP (formerly Freescale) platform having a >>>> Programmable Interrupt Timer (PIT). This timer is an IP found also on >>>> the NXP Automotive platform S32G2 and S32G3. >>>> >>>> Add the compatible for those platforms to describe the timer. >>>> >>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>>> --- >>>> .../devicetree/bindings/timer/fsl,vf610-pit.yaml | 8 ++++++-- >>>> 1 file changed, 6 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>>> index bee2c35bd0e2..2aac63a58bfd 100644 >>>> --- a/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>>> +++ b/Documentation/devicetree/bindings/timer/fsl,vf610-pit.yaml >>>> @@ -15,8 +15,12 @@ description: >>>> >>>> properties: >>>> compatible: >>>> - enum: >>>> - - fsl,vf610-pit >>>> + oneOf: >>>> + - const: fsl,vf610-pit >>>> + - const: nxp,s32g2-pit >>> >>> These 2 can be a single enum. Otherwise, >> >> Do you mean this ? >> >> enum: >> - fsl,vf610-pit >> - nxp,s32g2-pit >> > Yes. > And also please correct the subject prefix to match subsystem, git log > --oneline or: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Sure I'll replace it by: dt-bindings: timer: Add the PIT for s32g2 and s32g3 Thanks -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-31 8:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250730082725.183133-1-daniel.lezcano@linaro.org>
2025-07-30 8:27 ` [PATCH v2 19/20] dt: bindings: fsl,vf610-pit: Add compatible for s32g2 and s32g3 Daniel Lezcano
2025-07-30 23:36 ` Rob Herring
2025-07-31 7:41 ` Daniel Lezcano
2025-07-31 7:50 ` Krzysztof Kozlowski
2025-07-31 8:24 ` Daniel Lezcano
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).