From: Martin Schiller <ms@dev.tdt.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 04/12] net: dsa: lantiq_gswip: Use dev_err_probe where appropriate
Date: Thu, 13 Jun 2024 14:32:42 +0200 [thread overview]
Message-ID: <8592951129cec26ef55b43a99c5aa913@dev.tdt.de> (raw)
In-Reply-To: <20240613115137.ignzu35jxmmorxys@skbuf>
On 2024-06-13 13:51, Vladimir Oltean wrote:
> On Tue, Jun 11, 2024 at 03:54:26PM +0200, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>
>> dev_err_probe() can be used to simplify the existing code. Also it
>> means
>> we get rid of the following warning which is seen whenever the PMAC
>> (Ethernet controller which connects to GSWIP's CPU port) has not been
>> probed yet:
>> gswip 1e108000.switch: dsa switch register failed: -517
>>
>> Signed-off-by: Martin Blumenstingl
>> <martin.blumenstingl@googlemail.com>
>> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>
> Needs your sign off.
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
next prev parent reply other threads:[~2024-06-13 12:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 13:54 [PATCH net-next v5 00/12] net: dsa: lantiq_gswip: code improvements Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 01/12] dt-bindings: net: dsa: lantiq,gswip: convert to YAML schema Martin Schiller
2024-06-11 20:30 ` Rob Herring (Arm)
2024-06-13 11:46 ` Vladimir Oltean
2024-06-11 13:54 ` [PATCH net-next v5 02/12] net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU port Martin Schiller
2024-06-13 11:50 ` Vladimir Oltean
2024-06-13 12:32 ` Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 03/12] net: dsa: lantiq_gswip: add terminating \n where missing Martin Schiller
2024-06-13 11:49 ` Vladimir Oltean
2024-06-11 13:54 ` [PATCH net-next v5 04/12] net: dsa: lantiq_gswip: Use dev_err_probe where appropriate Martin Schiller
2024-06-13 11:51 ` Vladimir Oltean
2024-06-13 12:32 ` Martin Schiller [this message]
2024-06-11 13:54 ` [PATCH net-next v5 05/12] net: dsa: lantiq_gswip: Don't manually call gswip_port_enable() Martin Schiller
2024-06-13 11:52 ` Vladimir Oltean
2024-06-13 12:33 ` Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 06/12] net: dsa: lantiq_gswip: do also enable or disable cpu port Martin Schiller
2024-06-13 11:58 ` Vladimir Oltean
2024-06-11 13:54 ` [PATCH net-next v5 07/12] net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in gswip_port_change_mtu() Martin Schiller
2024-06-13 12:34 ` Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 08/12] net: dsa: lantiq_gswip: Change literal 6 to ETH_ALEN Martin Schiller
2024-06-13 12:35 ` Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 09/12] net: dsa: lantiq_gswip: Consistently use macros for the mac bridge table Martin Schiller
2024-06-13 12:00 ` Vladimir Oltean
2024-06-11 13:54 ` [PATCH net-next v5 10/12] net: dsa: lantiq_gswip: Remove dead code from gswip_add_single_port_br() Martin Schiller
2024-06-13 12:01 ` Vladimir Oltean
2024-06-11 13:54 ` [PATCH net-next v5 11/12] net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering() Martin Schiller
2024-06-13 12:02 ` Vladimir Oltean
2024-06-13 12:37 ` Martin Schiller
2024-06-11 13:54 ` [PATCH net-next v5 12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb() Martin Schiller
2024-06-13 11:48 ` Vladimir Oltean
2024-06-13 12:30 ` Martin Schiller
2024-06-12 2:00 ` [PATCH net-next v5 00/12] net: dsa: lantiq_gswip: code improvements Jakub Kicinski
2024-06-12 12:50 ` Martin Schiller
2024-06-14 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8592951129cec26ef55b43a99c5aa913@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).