From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH 10/15] ARM: dts: bcm: fix msi-controller name and unit address Date: Tue, 21 Mar 2017 23:07:34 -0700 Message-ID: <85acf150-aaa4-efee-c477-6d8e5ccfdf1d@broadcom.com> References: <20170322020313.24338-1-robh@kernel.org> <20170322020313.24338-10-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170322020313.24338-10-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Rob, On 3/21/2017 7:03 PM, Rob Herring wrote: > The unit address for the msi controller is not valid as there is no reg > property, so remove it. Also, msi-controller is the preferred node name. > > Signed-off-by: Rob Herring > Cc: Ray Jui > Cc: Scott Branden > Cc: Jon Mason > Cc: bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org > --- > Sub-arch maintainers, please apply to your trees unless arm-soc wants > to take the whole lot. > > arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++-- > arch/arm/boot/dts/bcm-nsp.dtsi | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index 8833a4c3cd96..9644fddb5e3c 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -205,7 +205,7 @@ > status = "disabled"; > > msi-parent = <&msi0>; > - msi0: msi@18012000 { > + msi0: msi-controller { > compatible = "brcm,iproc-msi"; > msi-controller; > interrupt-parent = <&gic>; > @@ -240,7 +240,7 @@ > status = "disabled"; > > msi-parent = <&msi1>; > - msi1: msi@18013000 { > + msi1: msi-controller { > compatible = "brcm,iproc-msi"; > msi-controller; > interrupt-parent = <&gic>; > diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > index 832795b0fd0f..42c017df490f 100644 > --- a/arch/arm/boot/dts/bcm-nsp.dtsi > +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > @@ -450,7 +450,7 @@ > status = "disabled"; > > msi-parent = <&msi0>; > - msi0: msi@18012000 { > + msi0: msi-controller { > compatible = "brcm,iproc-msi"; > msi-controller; > interrupt-parent = <&gic>; > @@ -486,7 +486,7 @@ > status = "disabled"; > > msi-parent = <&msi1>; > - msi1: msi@18013000 { > + msi1: msi-controller { > compatible = "brcm,iproc-msi"; > msi-controller; > interrupt-parent = <&gic>; > @@ -522,7 +522,7 @@ > status = "disabled"; > > msi-parent = <&msi2>; > - msi2: msi@18014000 { > + msi2: msi-controller { > compatible = "brcm,iproc-msi"; > msi-controller; > interrupt-parent = <&gic>; Looks good and thanks! Acked-by: Ray Jui -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html