From: "Rafał Miłecki" <zajec5@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"Al Cooper" <alcooperx@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema
Date: Sun, 3 Jan 2021 17:37:50 +0100 [thread overview]
Message-ID: <85c07078-906b-0d70-2214-874925f45c6f@gmail.com> (raw)
In-Reply-To: <20210103162329.GA3961287@robh.at.kernel.org>
On 03.01.2021 17:23, Rob Herring wrote:
> On Mon, Dec 21, 2020 at 06:23:37AM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Changes that require mentioning:
>> 1. interrupt-names
>> Name "wakeup" was changed to the "wake". It matches example and what
>> Linux driver looks for in the first place
>> 2. brcm,ipp and brcm,ioc
>> Both were described as booleans with 0 / 1 values. In examples they
>> were integers and Linux driver checks for int as well.
>> I made both uint32 but that probably should be refactored later.
>
> Why? You're stuck with that now.
"Why?" refactor later? I thought it makes more sense for boolean-like
settings to use boolean type. Just a slightly cleaner approach.
If we care to, I believe I can do that without breaking backward
compatibility. A simple value length check:
length 1: treat 0 as false, treat 1 as true
length 0: treat property existence as true
prev parent reply other threads:[~2021-01-03 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 5:23 [PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema Rafał Miłecki
2020-12-21 5:23 ` [PATCH V2 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding Rafał Miłecki
2021-01-03 16:24 ` [PATCH V2 2/3] dt-bindings: phy: brcm, brcmstb-usb-phy: " Rob Herring
2020-12-21 5:23 ` [PATCH V2 3/3] phy: phy-brcm-usb: support PHY on the BCM4908 Rafał Miłecki
2021-01-03 16:23 ` [PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema Rob Herring
2021-01-03 16:37 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85c07078-906b-0d70-2214-874925f45c6f@gmail.com \
--to=zajec5@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).