From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jiri Slaby" <jirislaby@kernel.org>,
"Elliot Berman" <quic_eberman@quicinc.com>,
"Bjorn Andersson" <quic_bjorande@quicinc.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Murali Nalajala" <quic_mnalajal@quicinc.com>,
"Trilok Soni" <quic_tsoni@quicinc.com>,
"Srivatsa Vaddagiri" <quic_svaddagi@quicinc.com>,
"Carl van Schaik" <quic_cvanscha@quicinc.com>,
"Prakruthi Deepak Heragu" <quic_pheragu@quicinc.com>,
"Andy Gross" <agross@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Marc Zyngier" <maz@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Will Deacon" <will@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 13/13] tty: gunyah: Add tty console driver for RM Console Services
Date: Tue, 11 Oct 2022 13:09:13 +0200 [thread overview]
Message-ID: <85ca7eb4-3e0c-4ffb-8bac-a435594ca0f7@app.fastmail.com> (raw)
In-Reply-To: <7438406d-b446-201e-0ec3-5cf0a5b9f32c@kernel.org>
On Tue, Oct 11, 2022, at 8:02 AM, Jiri Slaby wrote:
> On 11. 10. 22, 2:08, Elliot Berman wrote:
>> +
>> + /* below are for printk console.
>> + * gh_rm_console_* calls will sleep and console_write can be called from
>> + * atomic ctx. Two xmit buffers are used. The active buffer is tracked with
>> + * co_xmit_idx. Writes go into the co_xmit_buf[co_xmit_idx] buffer.
>> + * A work is scheduled to flush the bytes. The work will swap the active buffer
>> + * and write out the other buffer.
>> + */
>
> Ugh, why? This is too ugly and unnecessary. What about passing the kfifo
> to gh_rm_console_write() instead? You do memcpy() there anyway.
Another problem here is that you really want the console output to be
printed from atomic context, otherwise one would never see e.g. the
output of a panic() call. Having a deferred write is probably fine for
normal tty operations, but you probably want a different device for the
console here, e.g. the hvc_dcc driver.
Arnd
next prev parent reply other threads:[~2022-10-11 11:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 0:08 [PATCH v5 00/13] Drivers for gunyah hypervisor Elliot Berman
2022-10-11 0:08 ` [PATCH v5 01/13] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman
2022-10-11 9:36 ` Bagas Sanjaya
2022-10-11 0:08 ` [PATCH v5 02/13] dt-bindings: Add binding for gunyah hypervisor Elliot Berman
2022-10-12 15:56 ` Rob Herring
2022-10-13 23:58 ` Elliot Berman
2022-10-26 21:16 ` Rob Herring
2022-10-27 16:17 ` Elliot Berman
2022-10-27 19:55 ` Krzysztof Kozlowski
2022-11-01 3:19 ` Elliot Berman
2022-11-02 18:47 ` Krzysztof Kozlowski
2022-10-11 0:08 ` [PATCH v5 03/13] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman
2022-10-11 7:21 ` Greg Kroah-Hartman
2022-10-11 18:21 ` Elliot Berman
2022-10-11 18:48 ` Greg Kroah-Hartman
2022-10-11 18:50 ` Trilok Soni
2022-10-11 19:01 ` Greg Kroah-Hartman
2022-10-11 0:08 ` [PATCH v5 04/13] arm64: smccc: Include alternative-macros.h Elliot Berman
2022-10-11 7:22 ` Greg Kroah-Hartman
2022-10-11 22:45 ` Elliot Berman
2022-10-11 0:08 ` [PATCH v5 05/13] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman
2022-10-11 6:22 ` [PATCH v5 5/13] " Jiri Slaby
2022-10-12 21:31 ` [PATCH v5 05/13] " Dmitry Baryshkov
2022-10-11 0:08 ` [PATCH v5 06/13] virt: gunyah: Identify hypervisor version Elliot Berman
2022-10-11 6:13 ` Greg Kroah-Hartman
2022-10-13 23:00 ` Elliot Berman
2022-10-14 7:36 ` Greg Kroah-Hartman
2022-10-12 22:45 ` kernel test robot
2022-10-11 0:08 ` [PATCH v5 07/13] mailbox: Allow direct registration to a channel Elliot Berman
2022-10-11 0:08 ` [PATCH v5 08/13] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman
2022-10-11 0:08 ` [PATCH v5 09/13] mailbox: Add Gunyah message queue mailbox Elliot Berman
2022-10-12 21:47 ` Dmitry Baryshkov
2022-10-13 22:32 ` Elliot Berman
2022-10-17 8:43 ` Dmitry Baryshkov
2022-10-11 0:08 ` [PATCH v5 10/13] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman
2022-10-12 22:52 ` Dmitry Baryshkov
2022-10-13 22:32 ` Elliot Berman
2022-10-17 8:37 ` Dmitry Baryshkov
2022-10-11 0:08 ` [PATCH v5 11/13] gunyah: rsc_mgr: Add RPC for console services Elliot Berman
2022-10-11 0:08 ` [PATCH v5 12/13] gunyah: rsc_mgr: Add subdevices bus Elliot Berman
2022-10-11 0:08 ` [PATCH v5 13/13] tty: gunyah: Add tty console driver for RM Console Services Elliot Berman
2022-10-11 6:02 ` Jiri Slaby
2022-10-11 11:09 ` Arnd Bergmann [this message]
2022-10-11 22:04 ` Elliot Berman
2022-10-12 6:55 ` Greg Kroah-Hartman
2022-10-13 20:54 ` Elliot Berman
2022-10-14 7:38 ` Greg Kroah-Hartman
2022-10-11 18:22 ` Elliot Berman
2022-10-11 22:04 ` Elliot Berman
2022-10-11 17:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ca7eb4-3e0c-4ffb-8bac-a435594ca0f7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=agross@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_cvanscha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_pheragu@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).