From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16EEC433E0 for ; Mon, 1 Jun 2020 19:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBFB220734 for ; Mon, 1 Jun 2020 19:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="iwHH84UO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbgFATSa (ORCPT ); Mon, 1 Jun 2020 15:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbgFATS3 (ORCPT ); Mon, 1 Jun 2020 15:18:29 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49EFAC03E96B for ; Mon, 1 Jun 2020 12:18:28 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id b6so9620198ljj.1 for ; Mon, 01 Jun 2020 12:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/B/vJSdZ4H+DclQbmiiPRhS99BSxRaLniCcxhXNQdaA=; b=iwHH84UOoC537MGk6E7us+S+9Zdopz5u3Mz9r49FApyoOZsxNbMpSYkDpYz+aYUmIa gtYJ4Nu2LvDhSS9BFKk/dXVwM+V+xJdfWYttpRfsGqdl+mfJLbnevBNm+6jq/a3qu6CS 79cIP/nF1F5EzENa3hIe43wwl8d/B/SzpYMrgV+aDEoXxYeViLETePnqL6+klDaawcpX 9Q+NOyq2LouzXifA0UFaf9jIAdeXnxvtv9zoddLb2ACAVvgArDVoDnSfzqzGD6APHcu8 RWbhRoiDb2muv9dDnZFBL/MccbVhteizvEX7iahC7D4K1DHIFyVP4Ro83iNhRQPi/oNz WSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/B/vJSdZ4H+DclQbmiiPRhS99BSxRaLniCcxhXNQdaA=; b=HfNpgNOIb1NXyqMiUhr/Dbf0PlRJSzFJLALzJdizR9GfnXBTKYnKRHVHkLVrRUkqGZ vWZYOMdn12K2qkaRKb3N4svwFnUizJnlCvJ0zEBhumHdySH/rTl32z7HP8XcM41VcRa0 QNlZmATrCRmIlip46PiN7PuQ85R8BWstK7s4txZk86Ukxv2eoEbiZwleqUWmGi4yEttf d7dVYxUaCzc34aTm/g1p3fYNSTEr7wxldFUTeXxWxtEUM4qZQzyZb67qZFMZdk1pPZ8j 2DhMFRozpoAWc2KjBYJu/bI6jcVEFHbaKyyqRqr5JweMaMcTv2dF1RimO/i88bwc2eGP YHwA== X-Gm-Message-State: AOAM530ylHvPnbaFb4sWIO8ijAE7ardLpzq6dsMyILi6CEixLdK9WuGv G9IniVBTuFnFMQsVzlVmpXEQYdk3fMc= X-Google-Smtp-Source: ABdhPJy3cN4yLGJe+/Z+8B7cDMmCco1eIsfE3RnyFphuEUNzt9DcbvqKy/QmOpfmfS39sSO6wln/8A== X-Received: by 2002:a2e:970c:: with SMTP id r12mr11288156lji.145.1591039106548; Mon, 01 Jun 2020 12:18:26 -0700 (PDT) Received: from wasted.cogentembedded.com ([2a00:1fa0:42cb:40f3:c0fd:7859:f21:5d63]) by smtp.gmail.com with ESMTPSA id f12sm118393lfp.8.2020.06.01.12.18.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jun 2020 12:18:25 -0700 (PDT) Subject: Re: [PATCH v2 1/2] dt-bindings: memory: document Renesas RPC-IF bindings To: Rob Herring Cc: devicetree@vger.kernel.org, Mason Yang , linux-spi@vger.kernel.org, Chris Brandt , linux-mtd@lists.infradead.org References: <812e6e58-d13f-3f44-5f55-22266b690c57@cogentembedded.com> <116683d1-d402-4d7f-3357-1c8cde807076@cogentembedded.com> <20200501212547.GB15294@bogus> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <85e1ebd0-4b27-5382-c591-59d63d5b73de@cogentembedded.com> Date: Mon, 1 Jun 2020 22:18:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20200501212547.GB15294@bogus> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/02/2020 12:25 AM, Rob Herring wrote: >> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or >> HyperFlash connected to the SoC to be accessed via the external address >> space read mode or the manual mode. >> >> Document the device tree bindings for the Renesas RPC-IF found in the R-Car >> gen3 SoCs. >> >> Based on the original patch by Mason Yang . >> >> Signed-off-by: Sergei Shtylyov >> [...] >> Index: linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml >> =================================================================== >> --- /dev/null >> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml >> @@ -0,0 +1,88 @@ [...] >> +patternProperties: >> + "^.*@[0-9a-f]+$": > > ^flash@... if you're that restrictive. > >> + type: object >> + properties: >> + compatible: >> + oneOf: >> + - const: cfi-flash >> + - const: jedec,spi-nor > > enum is better than oneOf+const. - enum: - cfi-flash - jedec,spi-nor causes the build error you encountered while trying to merge the last time. What was I doing wrong? [...] MBR, Sergei