From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver Date: Sat, 24 Feb 2018 01:32:53 -0800 Message-ID: <85f66284-2e18-2a74-1e7b-9378353ab43e@linux.intel.com> References: <20180221161606.32247-1-jae.hyun.yoo@linux.intel.com> <20180221161606.32247-8-jae.hyun.yoo@linux.intel.com> <20180221182608.GA11635@roeck-us.net> <618f34cd-ee43-d8e4-4fb0-3c23bf03835f@linux.intel.com> <20180221214859.GA30263@roeck-us.net> <576a50c6-c302-654c-ceb3-aaf820b7738a@linux.intel.com> <20180222003720.GA25250@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miguel Ojeda Cc: linux-hwmon@vger.kernel.org, Andrew Lunn , jdelvare@suse.com, Arnd Bergmann , linux-doc@vger.kernel.org, andrew@aj.id.au, Greg KH , openbmc@lists.ozlabs.org, linux-kernel , devicetree@vger.kernel.org, joel@jms.id.au, benh@kernel.crashing.org, Guenter Roeck , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 2/23/2018 4:00 PM, Miguel Ojeda wrote: > On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo > wrote: >> On 2/21/2018 4:37 PM, Andrew Lunn wrote: >>>> >>>> But even with this change, it still needs to use delayed creation >>>> because BMC side kernel doesn't know how many DIMMs are populated on >>>> a remote server before the remote server completes its memory >>>> training and testing in BIOS, but it needs to check the remote >>>> server's CPU temperature as immediate as possible to make >>>> appropriate thermal control based on the remote CPU's temperature to >>>> avoid any critical thermal issue. What would be a better solution in >>>> this case? >>> >>> >>> You could change this driver so that it supports one DIMM. Move the >>> 'hotplug' part into another driver which creates and destroys >>> instances of the hwmon DIMM device as the DIMMS come and go. >>> >>> Also, do you need to handle CPU hotplug? You could split the CPU >>> temperature part into a separate hwmon driver? And again create and >>> destroy devices as CPUs come and go? >>> >>> Andrew >>> >> >> That seems like a possible option. I'll rewrite the hwmon driver again like >> that. >> >> Thanks for the good idea. :) > > By the way, in the rewrite, please try to avoid the create*workqueue() > functions (they are deprecated :). > > Cheers, > Miguel > Hi Miguel, Thanks for letting me know that. I'll replace that with alloc_workqueue(). :) Regards, Jae >> >> Jae