From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/8] arm64: dts: qcom: pm8550ve: make PMK8550VE SID configurable
Date: Wed, 25 Oct 2023 13:51:14 +0200 [thread overview]
Message-ID: <85f7eb5c-29ed-417a-a741-a3e7fe773d4b@linaro.org> (raw)
In-Reply-To: <6cedd9fe-ae5b-4173-9a77-ef4d7813a071@linaro.org>
On 25/10/2023 11:17, Krzysztof Kozlowski wrote:
> On 25/10/2023 09:47, Neil Armstrong wrote:
>> The pm8550ve can be found with a different SID on SM8650 platforms,
>> make it configurable.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/pm8550ve.dtsi | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8550ve.dtsi b/arch/arm64/boot/dts/qcom/pm8550ve.dtsi
>> index c47646a467be..fbd8a386cef2 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8550ve.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8550ve.dtsi
>> @@ -6,6 +6,11 @@
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/spmi/spmi.h>
>>
>> +/* (Sadly) this PMIC can be configured to be at different SIDs */
>> +#ifndef PMK8550VE_SID
>> + #define PMK8550VE_SID 5
>> +#endif
>
> My statement is still the same - NAK, for defines depending on ifndef. I
> believe outcome of our last discussion - including meeting in Amsterdam
> - was only to have defines in the board without any ifndef/ifdef.
As suggested by Dmitry, I'll add a define in all DT using the pm8550ve,
so this would remove any #ifndef.
Neil
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-10-25 11:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:47 [PATCH RFC 0/8] arm64: dts: qcom: Introduce SM8650 platforms device tree Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 1/8] dt-bindings: arm: qcom: document SM8650 and the reference boards Neil Armstrong
2023-10-25 9:13 ` Krzysztof Kozlowski
2023-10-25 7:47 ` [PATCH RFC 2/8] arm64: dts: qcom: add initial SM8650 dtsi Neil Armstrong
2023-10-25 9:01 ` Konrad Dybcio
2023-10-25 11:55 ` Neil Armstrong
2023-11-02 10:54 ` Neil Armstrong
2023-11-02 13:32 ` Konrad Dybcio
2023-11-06 8:22 ` neil.armstrong
2023-10-25 7:47 ` [PATCH RFC 3/8] arm64: dts: qcom: pm8550ve: make PMK8550VE SID configurable Neil Armstrong
2023-10-25 9:02 ` Konrad Dybcio
2023-10-25 9:03 ` Dmitry Baryshkov
2023-10-25 9:17 ` Krzysztof Kozlowski
2023-10-25 11:51 ` Neil Armstrong [this message]
2023-10-25 7:47 ` [PATCH RFC 4/8] arm64: dts: qcom: sm8650: add initial SM8650 MTP dts Neil Armstrong
2023-10-25 9:03 ` Konrad Dybcio
2023-10-25 7:47 ` [PATCH RFC 5/8] arm64: dts: qcom: sm8650: add initial SM8650 QRD dts Neil Armstrong
2023-10-25 9:03 ` Konrad Dybcio
2023-10-25 7:47 ` [PATCH RFC 6/8] arm64: dts: qcom: sm8650: add interconnect dependent device nodes Neil Armstrong
2023-10-25 9:10 ` Konrad Dybcio
2023-10-25 11:52 ` Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 7/8] arm64: dts: qcom: sm8650-mtp: " Neil Armstrong
2023-10-25 9:11 ` Konrad Dybcio
2023-10-25 11:54 ` Neil Armstrong
2023-10-25 7:47 ` [PATCH RFC 8/8] arm64: dts: qcom: sm8650-qrd: " Neil Armstrong
2023-10-25 9:11 ` Konrad Dybcio
2023-10-26 7:43 ` [PATCH RFC 0/8] arm64: dts: qcom: Introduce SM8650 platforms device tree Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f7eb5c-29ed-417a-a741-a3e7fe773d4b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).