* [PATCH] soundwire: qcom: remove redundant wait for completion
@ 2022-02-25 13:27 Srinivasa Rao Mandadapu
2022-02-25 13:37 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-02-25 13:27 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, koul, yung-chuan.liao, pierre-louis.bossart,
sanyog.r.kale
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Remove wait_for_completion_timeout from soundwire probe
as it seems unnecessary and device enumeration is anyway not
happening here.
Also, as device enumeration event is dependent on wcd938x probe to be
completed, its of no use waiting here.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/soundwire/qcom.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 5481341..9a32a24 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev)
}
qcom_swrm_init(ctrl);
- wait_for_completion_timeout(&ctrl->enumeration,
- msecs_to_jiffies(TIMEOUT_MS));
ret = qcom_swrm_register_dais(ctrl);
if (ret)
goto err_master_add;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: qcom: remove redundant wait for completion
2022-02-25 13:27 [PATCH] soundwire: qcom: remove redundant wait for completion Srinivasa Rao Mandadapu
@ 2022-02-25 13:37 ` Srinivas Kandagatla
2022-02-25 13:39 ` Srinivasa Rao Mandadapu
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Kandagatla @ 2022-02-25 13:37 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, lgirdwood,
broonie, robh+dt, quic_plai, bgoswami, perex, tiwai, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, koul, yung-chuan.liao, pierre-louis.bossart,
sanyog.r.kale
Cc: Venkata Prasad Potturu
On 25/02/2022 13:27, Srinivasa Rao Mandadapu wrote:
> Remove wait_for_completion_timeout from soundwire probe
> as it seems unnecessary and device enumeration is anyway not
> happening here.
May be some details on the side effects of this wait would be good to
add in the log.
> Also, as device enumeration event is dependent on wcd938x probe to be
> completed, its of no use waiting here.
fix tag is missing
Fixes: 06dd96738d618 ("soundwire: qcom: wait for enumeration to be
complete in probe")
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> drivers/soundwire/qcom.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 5481341..9a32a24 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct platform_device *pdev)
> }
>
> qcom_swrm_init(ctrl);
> - wait_for_completion_timeout(&ctrl->enumeration,
> - msecs_to_jiffies(TIMEOUT_MS));
> ret = qcom_swrm_register_dais(ctrl);
> if (ret)
> goto err_master_add;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soundwire: qcom: remove redundant wait for completion
2022-02-25 13:37 ` Srinivas Kandagatla
@ 2022-02-25 13:39 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-02-25 13:39 UTC (permalink / raw)
To: Srinivas Kandagatla, agross, bjorn.andersson, lgirdwood, broonie,
robh+dt, quic_plai, bgoswami, perex, tiwai, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, koul, yung-chuan.liao, pierre-louis.bossart,
sanyog.r.kale
Cc: Venkata Prasad Potturu
On 2/25/2022 7:07 PM, Srinivas Kandagatla wrote:
Thanks for Your time Srini!!
>
> On 25/02/2022 13:27, Srinivasa Rao Mandadapu wrote:
>> Remove wait_for_completion_timeout from soundwire probe
>> as it seems unnecessary and device enumeration is anyway not
>> happening here.
>
> May be some details on the side effects of this wait would be good to
> add in the log.
Okay. Will elaborate issue observed here.
>
>> Also, as device enumeration event is dependent on wcd938x probe to be
>> completed, its of no use waiting here.
>
> fix tag is missing
>
> Fixes: 06dd96738d618 ("soundwire: qcom: wait for enumeration to be
> complete in probe")
Okay. Will add and re post.
>
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> drivers/soundwire/qcom.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index 5481341..9a32a24 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -1309,8 +1309,6 @@ static int qcom_swrm_probe(struct
>> platform_device *pdev)
>> }
>> qcom_swrm_init(ctrl);
>> - wait_for_completion_timeout(&ctrl->enumeration,
>> - msecs_to_jiffies(TIMEOUT_MS));
>> ret = qcom_swrm_register_dais(ctrl);
>> if (ret)
>> goto err_master_add;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-25 13:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 13:27 [PATCH] soundwire: qcom: remove redundant wait for completion Srinivasa Rao Mandadapu
2022-02-25 13:37 ` Srinivas Kandagatla
2022-02-25 13:39 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).