Devicetree
 help / color / mirror / Atom feed
From: "Chawdhry, Manorit" <m-chawdhry@ti.com>
To: Eduard Bostina <egbostina@gmail.com>, <daniel.baluta@nxp.com>,
	<simona.toaca@nxp.com>, <goledhruva@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: arm: omap: Convert Counter-32K to DT schema
Date: Mon, 1 Jun 2026 12:41:26 +0530	[thread overview]
Message-ID: <862fcc54-376d-4bd4-a0fe-d34a14783156@ti.com> (raw)
In-Reply-To: <20260528165853.15510-1-egbostina@gmail.com>

Hi Eduard,

On 5/28/2026 10:28 PM, Eduard Bostina wrote:
> Convert the Texas Instruments OMAP Counter-32K bindings to DT schema.
>
> During the conversion, two updates were made to reflect actual hardware
> usage and resolve dtbs_check warnings:
> - 'ti,hwmods' has been made optional. While a search confirms it is no
>    longer used, it is kept to maintain backwards compatibility.
> - Added the 'ti,am4372-counter32k' compatible string, as an AM437x
>    device tree uses this instead of the generic 'ti,omap-counter32k'.

It's not instead, it's more of an alongside, the reason to keep this 
would be more of a backward
compatibility reason instead as we don't know if other software stacks 
relying on DTs are using
that compatible somehow.

Would be good to fix the commit message in v2 along with any other 
comments Krzysztof might have.

Regards,
Manorit

>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>   .../devicetree/bindings/arm/omap/counter.txt  | 15 -------
>   .../bindings/arm/omap/ti,omap-counter32k.yaml | 41 +++++++++++++++++++
>   2 files changed, 41 insertions(+), 15 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/arm/omap/counter.txt
>   create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,omap-counter32k.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/omap/counter.txt b/Documentation/devicetree/bindings/arm/omap/counter.txt
> deleted file mode 100644
> index 5bd8aa091..000000000
> --- a/Documentation/devicetree/bindings/arm/omap/counter.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -OMAP Counter-32K bindings
> -
> -Required properties:
> -- compatible:	Must be "ti,omap-counter32k" for OMAP controllers
> -- reg:		Contains timer register address range (base address and length)
> -- ti,hwmods:	Name of the hwmod associated to the counter, which is typically
> -		"counter_32k"
> -
> -Example:
> -
> -counter32k: counter@4a304000 {
> -	compatible = "ti,omap-counter32k";
> -	reg = <0x4a304000 0x20>;
> -	ti,hwmods = "counter_32k";
> -};
> diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap-counter32k.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap-counter32k.yaml
> new file mode 100644
> index 000000000..aadb5ea1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap-counter32k.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/omap/ti,omap-counter32k.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OMAP Counter-32K
> +
> +maintainers:
> +  - Eduard Bostina <egbostina@gmail.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: ti,omap-counter32k
> +      - items:
> +          - const: ti,am4372-counter32k
> +          - const: ti,omap-counter32k
> +
> +  reg:
> +    maxItems: 1
> +
> +  ti,hwmods:
> +    description: Name of the hwmod associated to the counter
> +    $ref: /schemas/types.yaml#/definitions/string-array
> +    items:
> +      - const: counter_32k
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    counter32k: counter@4a304000 {
> +        compatible = "ti,omap-counter32k";
> +        reg = <0x4a304000 0x20>;
> +        ti,hwmods = "counter_32k";
> +    };

  reply	other threads:[~2026-06-01  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 16:58 [PATCH] dt-bindings: arm: omap: Convert Counter-32K to DT schema Eduard Bostina
2026-06-01  7:11 ` Chawdhry, Manorit [this message]
2026-06-02 17:14 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=862fcc54-376d-4bd4-a0fe-d34a14783156@ti.com \
    --to=m-chawdhry@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=egbostina@gmail.com \
    --cc=goledhruva@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=simona.toaca@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox