From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC
Date: Wed, 15 Nov 2023 13:13:29 +0100 [thread overview]
Message-ID: <863a0fe2-c258-47d9-8563-6f12bb55b4ad@linaro.org> (raw)
In-Reply-To: <e766e663-0985-4a2e-8023-26ad0228157d@hatter.bewilderbeest.net>
On 14/11/2023 23:37, Zev Weiss wrote:
>
>>> + };
>>> +
>>> + memory@80000000 {
>>> + reg = <0x80000000 0x20000000>;
>>> + };
>>> +
>>> + leds {
>>> + compatible = "gpio-leds";
>>> +
>>> + heartbeat {
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
The node names are clearly wrong and you got output. It's easy to spot
if your patch worked in the first place:
fatal error: dt-bindings/watchdog/aspeed-wdt.h: No such file or directory
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-15 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 11:27 [PATCH 0/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC Zev Weiss
2023-11-14 11:27 ` [PATCH 1/2] dt-bindings: arm: aspeed: document ASRock E3C256D4I Zev Weiss
2023-11-14 20:34 ` Krzysztof Kozlowski
2023-11-14 11:27 ` [PATCH 2/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC Zev Weiss
2023-11-14 20:35 ` Krzysztof Kozlowski
2023-11-14 22:21 ` Zev Weiss
2023-11-15 12:13 ` Krzysztof Kozlowski
2023-11-14 22:37 ` Zev Weiss
2023-11-14 22:55 ` Zev Weiss
2023-11-15 12:13 ` Krzysztof Kozlowski [this message]
2023-11-16 2:39 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863a0fe2-c258-47d9-8563-6f12bb55b4ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).