* [PATCH v3] arm64: dts: stratix10: fix multicast filtering
@ 2018-11-02 19:10 Aaro Koskinen
2018-11-05 19:14 ` Dinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2018-11-02 19:10 UTC (permalink / raw)
To: Dinh Nguyen, Thor Thayer, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, netdev, Aaro Koskinen
From: Aaro Koskinen <aaro.koskinen@nokia.com>
On Stratix 10, the EMAC has 256 hash buckets for multicast filtering. This
needs to be specified in DTS, otherwise the stmmac driver defaults to 64
buckets and initializes the filter incorrectly. As a result, e.g. valid
IPv6 multicast traffic ends up being dropped.
Fixes: 78cd6a9d8e15 ("arm64: dts: Add base stratix 10 dtsi")
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
1 file changed, 3 insertions(+)
v3: Send the patch using sane SMTP server to preserve the correct
formatting.
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 8253a1a9e985..fef7351e9f67 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -139,6 +139,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};
@@ -154,6 +155,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};
@@ -169,6 +171,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] arm64: dts: stratix10: fix multicast filtering
2018-11-02 19:10 [PATCH v3] arm64: dts: stratix10: fix multicast filtering Aaro Koskinen
@ 2018-11-05 19:14 ` Dinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Dinh Nguyen @ 2018-11-05 19:14 UTC (permalink / raw)
To: Aaro Koskinen, Thor Thayer, Rob Herring, Mark Rutland
Cc: devicetree, linux-kernel, netdev, Aaro Koskinen
On 11/2/18 2:10 PM, Aaro Koskinen wrote:
> From: Aaro Koskinen <aaro.koskinen@nokia.com>
>
> On Stratix 10, the EMAC has 256 hash buckets for multicast filtering. This
> needs to be specified in DTS, otherwise the stmmac driver defaults to 64
> buckets and initializes the filter incorrectly. As a result, e.g. valid
> IPv6 multicast traffic ends up being dropped.
>
> Fixes: 78cd6a9d8e15 ("arm64: dts: Add base stratix 10 dtsi")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied!
Thanks,
Dinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-05 19:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02 19:10 [PATCH v3] arm64: dts: stratix10: fix multicast filtering Aaro Koskinen
2018-11-05 19:14 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).