devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Conor Dooley <conor@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32
Date: Wed, 10 Jul 2024 12:32:20 +0200	[thread overview]
Message-ID: <863e5bcd9160090f3b9a93f70da0de50d5efbe9a.camel@pengutronix.de> (raw)
In-Reply-To: <20240701-evolve-unbutton-ef7d913ad69f@spud>

On Mo, 2024-07-01 at 15:42 +0100, Conor Dooley wrote:
> On Mon, Jul 01, 2024 at 02:47:50PM +0200, Philipp Zabel wrote:
> > Hi Conor,
> > 
> > On Fr, 2024-06-28 at 17:21 +0100, Conor Dooley wrote:
> > > On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> > > > Add compatible for EXC81W32 touchscreen controllers.
> > > 
> > > Could you please mention in your commit messages what makes a fallback
> > > compatible inappropriate here?
> > 
> > thank for pointing this out. Actually, I'm not sure a fallback
> > compatible is inappropriate at all. There just is none currently, even
> > though EXC80H60 and EXC80H84 already look compatible to me.
> > 
> > To my understanding, there's EXC80[WH]{32,46,60,84} models, that should
> > only differ in ball pitch (W or H) and targeted display size (the last
> > number).
> > I don't know if there are actual relevant differences between what I
> > assume are model generations, such as EXC80 to EXC81. At least the
> > limited currently implemented feature set in the exc3000 driver is
> > identical.
> > 
> > Given that EXC80H60, EXC80H84, and now EXC81W32 all share the same 16K
> > resolution and the same message format (possible differences in
> > capability to measure touch area nonwithstanding), should I prepend
> > this series with a patch:
> 
> If you're prepared to update the two users to avoid adding more
> dtbs_check warnings, sure.

I'll follow up with another patch series, thanks.

regards
Philipp

  reply	other threads:[~2024-07-10 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  8:35 [PATCH v2 0/2] Input: exc3000 - EXC81W32 controller support Philipp Zabel
2024-06-28  8:35 ` [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add EXC81W32 Philipp Zabel
2024-06-28 16:21   ` Conor Dooley
2024-07-01 12:47     ` Philipp Zabel
2024-07-01 14:42       ` Conor Dooley
2024-07-10 10:32         ` Philipp Zabel [this message]
2024-06-28  8:35 ` [PATCH v2 2/2] Input: exc3000 - add EXC81W32 support Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=863e5bcd9160090f3b9a93f70da0de50d5efbe9a.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).