From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of Date: Tue, 11 Feb 2014 16:23:56 +0100 Message-ID: <8648675.AIXYyYlgXy@avalon> References: <1392119105-25298-1-git-send-email-p.zabel@pengutronix.de> <20140211145248.GI26684@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20140211145248.GI26684@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Rob Herring , Philipp Zabel , Mauro Carvalho Chehab , Grant Likely , Rob Herring , Sylwester Nawrocki , Tomi Valkeinen , Kyungmin Park , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , Philipp Zabel List-Id: devicetree@vger.kernel.org Hi Russell, On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote: > On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > > This allows to reuse the same parser code from outside the V4L2 > > > framework, most importantly from display drivers. There have been > > > patches that duplicate the code (and I am going to send one of my own), > > > such as > > > http://lists.freedesktop.org/archives/dri-devel/2013-August/043308.html > > > and others that parse the same binding in a different way: > > > https://www.mail-archive.com/linux-omap@vger.kernel.org/msg100761.html > > > > > > I think that all common video interface parsing helpers should be moved > > > to a single place, outside of the specific subsystems, so that it can > > > be reused by all drivers. > > > > Perhaps that should be done rather than moving to drivers/of now and > > then again to somewhere else. > > Do you have a better suggestion where it should move to? > > drivers/gpu/drm - no, because v4l2 wants to use it > drivers/media/video - no, because DRM drivers want to use it > drivers/video - no, because v4l2 and drm drivers want to use it Just pointing out a missing location (which might be rejected due to similar concerns), there's also drivers/media, which isn't V4L-specific. > Maybe drivers/of-graph/ ? Or maybe it's just as good a place to move it > into drivers/of ? -- Regards, Laurent Pinchart