From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E81C77B71 for ; Tue, 18 Apr 2023 08:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbjDRI6X (ORCPT ); Tue, 18 Apr 2023 04:58:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbjDRI6W (ORCPT ); Tue, 18 Apr 2023 04:58:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90D1940CC; Tue, 18 Apr 2023 01:58:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 237B461B1C; Tue, 18 Apr 2023 08:58:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87CA8C4339B; Tue, 18 Apr 2023 08:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681808300; bh=6EWDuT9BK2t/NojfkXHhe5k4tKvwwjUp3xxUbWkwuQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ice0nWwUnip0G6hrEh+4jPXMmTf9k3GNigbkBnQ/XojK2JTU4zFHlEg4Z3Tza02iS OJ+++I5+ebRxtWE6TXA0xjXjeeX8b2oQcvG+O2ZwtSb7GHLEo5LWSnOH3f3xHMssug 6dDV5HUjgLWXzcX85K2FDvSOhPlu1wX3ZpdCgt1XtYzDbQUMYRCUEsAkpq/zhyFkGU 7pDmw07eX3pEzfyA7ND8V6gmo0JJSyFid0RXu879RZpE8J1QZMWqhIuYGPaPIYjz5m Y1889lVnIgMZJfk3AM4jCVFKsV//e0q5EQPQtrfIRagd4irl+gSchm5iYKRz3HH5eB PwUIAkpQGdV/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pohAI-009Fdf-9g; Tue, 18 Apr 2023 09:58:18 +0100 Date: Tue, 18 Apr 2023 09:58:17 +0100 Message-ID: <865y9tlg7q.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Thomas Gleixner , Peng Fan , Robin Murphy , Peter Geis , XiaoDong Huang , Kever Yang , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 1/2] irqchip/gic-v3: Add Rockchip 3588001 errata workaround In-Reply-To: <20230417214033.25ckpswkjj6twfot@mercury.elektranox.org> References: <20230417150038.51698-1-sebastian.reichel@collabora.com> <20230417150038.51698-2-sebastian.reichel@collabora.com> <86a5z6lbuv.wl-maz@kernel.org> <20230417214033.25ckpswkjj6twfot@mercury.elektranox.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastian.reichel@collabora.com, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de, peng.fan@nxp.com, robin.murphy@arm.com, pgwipeout@gmail.com, derrick.huang@rock-chips.com, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 17 Apr 2023 22:40:33 +0100, Sebastian Reichel wrote: > > Hi, > > On Mon, Apr 17, 2023 at 05:20:08PM +0100, Marc Zyngier wrote: > >> [...] > > Please see below for an untested diff against your patch, addressing > > most of the issues mentioned here. > > Thanks, looks good. I integrated the changes into v3. > > > Also, I don't see anything here addressing the *other* bug this > > platform suffers from, which is the 32bit limit to the allocations. > > Without a fix for it, this patch is pointless as the GIC may end-up > > with memory it cannot reach. > > > > What;s the plan for that? > > It got fixed in RK3588. So what's the plan for the affected SoCs? It might be a good idea to address it too, unless there are none of them in the wild? M. -- Without deviation from the norm, progress is not possible.