From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36050C77B78 for ; Thu, 4 May 2023 09:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbjEDJgR (ORCPT ); Thu, 4 May 2023 05:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbjEDJgQ (ORCPT ); Thu, 4 May 2023 05:36:16 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB60846BA for ; Thu, 4 May 2023 02:36:14 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50bcb00a4c2so344379a12.1 for ; Thu, 04 May 2023 02:36:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683192973; x=1685784973; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mRcoOC8fngP6Il2rAzvXIOhnaTFot/xB1pDV/8xXBhI=; b=MM3fLTuvY1THuF+Jes6bTaFgdLgelBxjG9Qs0YrJ62r2rXYT0XrFa3z3syIzosle/b ndQzUCfwxP0iURGIxMkTVDjBIChW3aQKQa5lej+0hWz/zOU+BYcZpLtkfqufI9lhZ7es qhlX/+ZSVEuTfyzLRaTd7wSuwjcjxrMHgq8WR24DyKR0x1kNqmw1BPJywXnPdZSaw/uQ v66XZknaiYzEr+EDAw3mGYpAzFgZ8hMx+Krhne2k4sav+gyjx359mGzZ3ot1qt34/94A ghRo/Cb+pg7QBb8ZQd8FiQIU4dfjKh2kVt6C+eOHJNmtQ6FMaiDDLxp2MrDt/PzbP4MN 7bgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683192973; x=1685784973; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mRcoOC8fngP6Il2rAzvXIOhnaTFot/xB1pDV/8xXBhI=; b=VYEigwdJOyfZ4T9y0XBQg78oOvRv/+0TK7SxExbwW9+4UtdFvFaMK6uTY/XiSIch9Q VJPw0+AC6Fx92vmI4dlz62E6mY573hM5tg8HtPt3wGpr3ky9r21WKbpU88xcJ08BSuz+ O24lvCC37OkrvkxWEWId3XR2MYlgww03GaJLekXGPWR4vroI12iJeMLwZ/rH4rVu63gB fOVOduxKucg3NAife4QoA5FJKon6eZaY5ejnnywvwF5eIJSl4QaRAsY7whMpCpXpedkN fiehBoWGD7O0iJR2x6GeqBdK1HXuSjauvSOhjgfbrcR6DhkM5MlZlGBRtQC0K2ZzGmZj FF+g== X-Gm-Message-State: AC+VfDy+h4RAvDTURbXnzqeS1kCeuvFLvyuZ3dQIxBi8QmFKqUcPPap2 cUPSPM/Q7hqxPGdxfPohK/lL2w== X-Google-Smtp-Source: ACHHUZ76/GLGEckds5wB/s6mHv5yN0exDgClTi+UZl555s4ZPAcE2DRB69WKyTxronDQzYc5TFp31A== X-Received: by 2002:a17:907:1b08:b0:957:1df0:9cbf with SMTP id mp8-20020a1709071b0800b009571df09cbfmr6548125ejc.19.1683192973372; Thu, 04 May 2023 02:36:13 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:cbf1:e7ef:fb81:e912? ([2a02:810d:15c0:828:cbf1:e7ef:fb81:e912]) by smtp.gmail.com with ESMTPSA id sb21-20020a170906edd500b0094f4d2d81d9sm18480946ejb.94.2023.05.04.02.36.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 02:36:12 -0700 (PDT) Message-ID: <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> Date: Thu, 4 May 2023 11:36:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Changhuang Liang , Conor Dooley Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, vkoul@kernel.org, linux-phy@lists.infradead.org References: <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> <0988495f-b87a-7f69-f222-37c67d6eae23@starfivetech.com> <20230425-resale-footrest-de667778c4fe@wendy> <663e9933-b9b3-a48f-98b6-2207215a8ed7@starfivetech.com> <20230425-commotion-prewashed-876247bed4ab@spud> <0b0f9187-ad6b-a1d9-6ec4-beb8989ca731@starfivetech.com> <3ed72340-accc-4ad1-098f-4a2eb6448828@linaro.org> <482e812a-05dd-105c-189c-e926b4be9d28@starfivetech.com> <089e24d1-588a-4a56-f00b-0b35d1d99295@linaro.org> <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/05/2023 10:43, Changhuang Liang wrote: > > > On 2023/5/4 15:26, Krzysztof Kozlowski wrote: >> On 04/05/2023 09:20, Changhuang Liang wrote: >>>>> >>>>> Krzysztof, >>>>> >>>>> I am confused about what to do next. How to add this power-controller's >>>>> node in device tree? >>>>> >>>> >>>> You just move power-domain-cells up. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Like this? >>> >>> aon_syscon: syscon@17010000 { >>> compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"; >>> reg = <0x0 0x17010000 0x0 0x1000>; >>> #power-domain-cells = <1>; >>> }; >>> >>> If right? I will tell the syscon patch's owner delete the "simple-mfd" in aon_syscon node. >> >> Yes, but your compatibles are now wrong. Just compatible = >> "starfive,jh7110-aon-syscon", "syscon". >> > > If compatible = "starfive,jh7110-aon-syscon", "syscon". My pmu drivers need use > "starfive,jh7110-aon-syscon" to match. And how it would even work with your proposal "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"? Try... > And my pmu series will add this > aon_syscon in yaml and device tree, so the syscon patch's owner don't need > to add the aon_syscon in its yaml and device tree? I don't understand. But if you need to drop syscon, sure, drop it. Best regards, Krzysztof