From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D888C433FE for ; Thu, 31 Mar 2022 06:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231166AbiCaGbN (ORCPT ); Thu, 31 Mar 2022 02:31:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbiCaGbM (ORCPT ); Thu, 31 Mar 2022 02:31:12 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B75F17058 for ; Wed, 30 Mar 2022 23:29:22 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id dr20so45897302ejc.6 for ; Wed, 30 Mar 2022 23:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=M7HnRXS8ki9auACx5m4t264mmjUE2bAJ8U4PZKnd4Ho=; b=gIutq7OiCYAR4J7scRouIcS85qZpcD3wP3KFhISUJKkMRweNyECinL3s6VWksrnTPL McNk7ELEplAZFydI9Ihx3pXyvb2DWGk669kxevLxwlmn7Itszsub3kmsr1cFU2okLvK/ tv6ymHuwfrgJORnpLyy1FQpXtfMDoa5qM60AvIGx/hoggt7US2Mubbc/+W31tXakeU6g 5n7+yzG6ejb4dx1G9rEFiYJHnBvgx7fz55gw1kgyHYAkG1CY5GvKoSpig5UDSoKLVWSS PsPgh8kkls9K1tDvYfgZfJ1Ww2smKOB1Jiik2u3F67WCpgjy14UJrgeFBlGQJzCzHDww b9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=M7HnRXS8ki9auACx5m4t264mmjUE2bAJ8U4PZKnd4Ho=; b=djSKLGfjxguo5jMk5hTWHh0UfsrK0JSV18W5/mLxQNM73jB2DwF/Jpu2oZ4PYdM7fQ GOM3hXUaYCxD0IN9Vx5r97veROY9pJSQBr4EDlgP56mdRxmzyawMrxL6PdCROtGrP8MC Qa4sgL8zZ0Vxvfawzuf+2zivX+u0klJrgPEsG+kHre0TY/BImgj/KkJ2t9xfiCXILC1u Ev5xEo7YXprYTfJf5hzetvmbH+mh6wQQhN60LAnPqm/9+DcVRJhgcIp5tsuj6muF2K88 lX8J316nLYg+imLI1cUYCtaiE+g+GG8UP79mhQE0XwEgxumldJY6tsobjAkcGLuLb8Rh S/+Q== X-Gm-Message-State: AOAM532Slxho+K3tYSicPhzWnkfTZ/XQI2cqt2b4d7glCBLRO/Tl95Am VP1x1j2HuyTmaSDnw6tvA6fV4A== X-Google-Smtp-Source: ABdhPJwevveOArflEso+HTdUotyheR45XpywF2kU6sgy5+5pNxmXLHHbHCqLA7sF9nDwnvz7C0JDEg== X-Received: by 2002:a17:907:7ea6:b0:6db:ca53:9b0a with SMTP id qb38-20020a1709077ea600b006dbca539b0amr3506829ejc.763.1648708160890; Wed, 30 Mar 2022 23:29:20 -0700 (PDT) Received: from [192.168.0.165] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id ep16-20020a1709069b5000b006daa26de2fbsm8894521ejc.153.2022.03.30.23.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 23:29:20 -0700 (PDT) Message-ID: <866c6b42-434d-e7db-5319-2256cd7003d7@linaro.org> Date: Thu, 31 Mar 2022 08:29:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller Content-Language: en-US To: Jacky Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, cfli0@nuvoton.com References: <20220331024256.14762-1-ychuang3@nuvoton.com> <20220331024256.14762-2-ychuang3@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <20220331024256.14762-2-ychuang3@nuvoton.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2022 04:42, Jacky Huang wrote: > Add the dt-bindings header for Nuvoton MA35D1, that gets shared > between the clock controller and clock references in the dts. > > Signed-off-by: Jacky Huang > --- > .../dt-bindings/clock/nuvoton,ma35d1-clk.h | 262 ++++++++++++++++++ > 1 file changed, 262 insertions(+) > create mode 100644 include/dt-bindings/clock/nuvoton,ma35d1-clk.h > > diff --git a/include/dt-bindings/clock/nuvoton,ma35d1-clk.h b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h > new file mode 100644 > index 000000000000..3634e5edcac5 > --- /dev/null > +++ b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h > @@ -0,0 +1,262 @@ > +/* SPDX-License-Identifier: GPL-2.0+ OR MIT */ Can you make it the same license as bindings? > +/* > + * Copyright (c) 2022 Nuvoton Technology Corporation. > + */ > + > +#ifndef __DT_BINDINGS_MA35D1_CLK_H > +#define __DT_BINDINGS_MA35D1_CLK_H > + > +/* Clock Sources */ > +/* External and Internal oscillator clocks */ > +#define HXT 0 One space after '#define'. Please do not introduce some non-Linux coding style. Best regards, Krzysztof