From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFB321BC2F; Wed, 29 May 2024 14:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716991238; cv=none; b=P937SAfDAPq8ZIfEazOxcqbd7Mzn4cXy1oJJlQGBOYwjUxbK4qGAqSISFfQSKos1izFoRRHrM02k6b4Ha4XcUh5jhQtBItLkCUjiMhIYXlaMierag+hJ9fJaXW3hYJHN8dK0SkHGKm5g6w5ZO5lDO7Q+0LviJlKyNJWhFmn2vPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716991238; c=relaxed/simple; bh=QrqwButrkMVOdpfgULKi8N8/H/ojCzpow3uoRbSfgDM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=nP9AePMvjWa1hSENElyqnCRuR5wshptE32M7YKj7TvnnKT86PnWexpY+3lcrpM9ZVgpEAkSTpyzcUlFuN97/OHRxMHsOUJWZ9+z3NOtE8U6o8CbeI0BkDkXr1CXShqYAgAbiwd00HGd9UFMboz94sZ/wFD9JMFGokDqSl5Q+L8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KickmQUY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KickmQUY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 202C4C113CC; Wed, 29 May 2024 14:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716991237; bh=QrqwButrkMVOdpfgULKi8N8/H/ojCzpow3uoRbSfgDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KickmQUYv1vEyABdW51kYlRjaL6kwtPkx/zYRqaD06XMhjE+Jc1ihr46SS8Sm36K+ gk+qVZJIH/r4oDkPx94o0KyV5tmXH3uC/eLbxlLjIUKG4fUxEGZKo11XUIn5yfeGdk QaaaTj1hPfxvOeqHDRz9moRsgSl9eHlDVQ3TCAkgVX82fERCj0ztwq7Jz5zVL/6tRK ZlFoSgz79zgcVFMJssIfpS/uIUmbp1sNCIVhMuh/VBLyz5Q7n2InR5VSiOXkvRREV1 hb/Kq8DxV0RWZ5a8HQLsbSwenOelWRiJ1wBcMNTnJECURYHPWL/lTOTDOhMtW47lJf dXTApY7ooFmLw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCJr0-00Gdfc-NU; Wed, 29 May 2024 15:00:34 +0100 Date: Wed, 29 May 2024 15:00:34 +0100 Message-ID: <867cfcn2f1.wl-maz@kernel.org> From: Marc Zyngier To: Rob Herring Cc: Anup Patel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Saravana Kannan Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map In-Reply-To: References: <20240528164132.2451685-1-maz@kernel.org> <86bk4pm8j1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robh@kernel.org, apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, saravanak@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 May 2024 14:44:07 +0100, Rob Herring wrote: >=20 > On Wed, May 29, 2024 at 1:33=E2=80=AFAM Marc Zyngier wro= te: > > > > On Wed, 29 May 2024 06:15:52 +0100, > > Anup Patel wrote: > > > > > > This breaks for RISC-V because we don't have "#address-cells" > > > property in interrupt controller DT node and of_bus_n_addr_cells() > > > retrieves "#address-cells" from the parent of interrupt controller. > > > > That's a feature, not a bug. #address-cells, AFAICT, applies to all > > child nodes until you set it otherwise. >=20 > That may be supported in some places, but only because of buggy DTs > (we're talking 2000 era). Current dtc should warn if an interrupt > controller node doesn't have #address-cells AND is referred to by > interrupt-map. Clearly that didn't deter the riscv folks from doing silly things, and we're now stuck with more random hacks. Anyhow, I vented enough about this, and I'm going back to doing semi-useful stuff. M. --=20 Without deviation from the norm, progress is not possible.