From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4567E13ADB; Wed, 14 Feb 2024 09:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707904365; cv=none; b=dv6BTQoBF3ndMqFsEmO5bEDWbIwp76o001A0OrTW1TbACNs/WKTYyz/vyn2y+sx8bva+NUWXGIROcIJuOAyDYNcquWU9ONIL41ry2yKPy1s8l7QY6FT6yiPDuTGjiF1BJaBl0Lh0vlp46RkpeLxn8suIxZv4Yyp+MSs5y+2ckiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707904365; c=relaxed/simple; bh=4ITR0NaF2IXIbe34i/5k34/8TGKN+3qf0hadVySymOY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=TIP9vzIOt6xn2vQRvZc0o31Fbm40t8O5XDnNLMCkVhx+DnkOBB4BkbrDV5xduyQQHNdrtFFlA9wAf4L9FwhvXNwexWpG97HtQk7TlQs8gjb9DEBZkYjD+SysrHKBI62BGrJe+EdIqTLJ18tSuhGfHv2+usbhfltjxaMleWUNHmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pnIYhYCB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pnIYhYCB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8100C433C7; Wed, 14 Feb 2024 09:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707904364; bh=4ITR0NaF2IXIbe34i/5k34/8TGKN+3qf0hadVySymOY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pnIYhYCBuhpeg3T5OinEnaE7B9fUDvzhXQJ4JOuzEH4eteSInkiU/TwDS0wFFAmL2 UEyceDLnLmI/Ur1O3CMqSnpmqhDhUL1e8onL1nweUuA3vF0JSxx3sgRYvvpheqhZMl MxRiGrPkPu1gYH2/Xucs7HC7/FSjadpGxumhSJto9FsVA2GnkCTlS4afZUpdMPgW/y fUYKymtT9IodkCQFtAvw34ZFh0cKNyY0ksvIshmR8nRgeXKh6pmw60MK/hFyDMzLrJ JK0uiuyKSJlR3lx80SFRD0RvnT6i64IdNb6O9JkjqTKxeUJARGUxiA3edA3+gs/5OO h8qBnNFOByH5w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1raBwY-0035aU-0R; Wed, 14 Feb 2024 09:52:42 +0000 Date: Wed, 14 Feb 2024 09:52:41 +0000 Message-ID: <867cj75q52.wl-maz@kernel.org> From: Marc Zyngier To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , Rob Herring , Arnd Bergmann , Philipp Zabel , Peter Rosin , devicetree@vger.kernel.org Subject: Re: [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it In-Reply-To: <20240213225619.11726-1-rdunlap@infradead.org> References: <20240213225619.11726-1-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rdunlap@infradead.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, robh@kernel.org, arnd@arndb.de, p.zabel@pengutronix.de, peda@axentia.se, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 13 Feb 2024 22:56:19 +0000, Randy Dunlap wrote: > > IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set > it directly thru "make *config", so drivers should select it instead > of depending on it if they need it. > Relying on it being set for a dependency is risky. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change OF_IRQ's use of "depends on" to "select". > > This patch reduces one Kconfig circular dependency in > drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP (a failed > patch), which that driver needs (but does not completely resolve that > issue). [1] > > before this patch: (10 lines of detail) > drivers/net/ethernet/arc/Kconfig:19:error: recursive dependency detected! > drivers/net/ethernet/arc/Kconfig:19: symbol ARC_EMAC_CORE is selected by ARC_EMAC > drivers/net/ethernet/arc/Kconfig:26: symbol ARC_EMAC depends on OF_IRQ > drivers/of/Kconfig:81: symbol OF_IRQ depends on IRQ_DOMAIN > kernel/irq/Kconfig:60: symbol IRQ_DOMAIN is selected by REGMAP > drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by MUX_MMIO > drivers/mux/Kconfig:48: symbol MUX_MMIO depends on MULTIPLEXER > drivers/mux/Kconfig:6: symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER > drivers/net/mdio/Kconfig:275: symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_DEVICE > drivers/net/mdio/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB > drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by ARC_EMAC_CORE > > after this patch: (5 lines of detail) > drivers/mux/Kconfig:6:error: recursive dependency detected! > drivers/mux/Kconfig:6: symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER > drivers/net/mdio/Kconfig:275: symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_BUS > drivers/net/mdio/Kconfig:13: symbol MDIO_BUS is selected by REGMAP > drivers/base/regmap/Kconfig:6: symbol REGMAP is selected by MUX_MMIO > drivers/mux/Kconfig:48: symbol MUX_MMIO depends on MULTIPLEXER > > [1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/ > > Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN") > Signed-off-by: Randy Dunlap > Cc: Geert Uytterhoeven > Cc: Rob Herring > Cc: Marc Zyngier > Cc: Arnd Bergmann > Cc: Philipp Zabel > Cc: Peter Rosin > Cc: devicetree@vger.kernel.org > --- > v2: update patch description, rebase & resend > > drivers/of/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -80,7 +80,8 @@ config OF_ADDRESS > > config OF_IRQ > def_bool y > - depends on !SPARC && IRQ_DOMAIN > + depends on !SPARC > + select IRQ_DOMAIN > > config OF_RESERVED_MEM > def_bool OF_EARLY_FLATTREE > This seems to be moving is the right direction. FWIW, Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.