From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E1933509F; Tue, 21 Oct 2025 15:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761059727; cv=none; b=DOe5LEOaiUwq1SA7fbzvQnYYGWcu1MBSaB9zBYaJg9kFEemwChApdi0cGwlKkirVRk/j0/LHuhz1/6cq1qloN1TXPwlG30fpqLE3Itu4ROS1719KGe3JRRHLrGlERdTpw36/cv173ax6ag+rcOZ5jihqgC8wDpo8btfqZVpiPxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761059727; c=relaxed/simple; bh=MgCXam1/mW0SmqZK+U1KcPTrQ31DfIrbzGnwcNoUJAo=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EsToM7RZTmm7UDQQef4Y0M1Yyvcuj4dPZihIDAJ0Z+cC4FN/PClhyxIf56B9JPoaHh75HBFHkqNSiezjDw7/qIngrnrzQwXr+U3vKROKwq5Uf8TSyJlySMGz1mXfBrRkSzOF38UDikU/Dsvgp7vdCSsv8UNnJdN3EjGcD0H5AwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mznYIcle; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mznYIcle" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4771C4CEF1; Tue, 21 Oct 2025 15:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761059726; bh=MgCXam1/mW0SmqZK+U1KcPTrQ31DfIrbzGnwcNoUJAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mznYIclegWDskvSCmLAaalFM0uFXHZtex0TSHbihITxS2pbRir/3KXk12MRxco4ss Z8CpuUCd+ihY4fF6y/N+uC4e5rGHSynPC2qICWCclMsiCmkaNlxc4lyhNaX5ThNiMi gT3G1cdtAxeDwCGhcXw4dx5BesSxIwN1CebQOIQ5wdtgFICJw0acGIKSsgK0Azyv+9 56VAWXZcu50+l0yevg4Woj2qtQIfJlwF/FuN4YgkRPPSfx+Lr79GHc3W5dg28nhz3P QEo/SUdvo5rHFMgzLhtDIwwy2czuuNhi9rHoLK16f1ufJZdV8DyZ8E7pikDkaLgjay C1iIkch+9VX+A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vBE56-0000000FtDi-1fUu; Tue, 21 Oct 2025 15:15:24 +0000 Date: Tue, 21 Oct 2025 16:15:23 +0100 Message-ID: <868qh4wak4.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Frank Li , Sascha Bischoff , Thomas Gleixner , Rob Herring , Scott Branden , Bjorn Helgaas , Ray Jui , Manivannan Sadhasivam , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= Subject: Re: [PATCH v4 5/5] irqchip/gic-its: Rework platform MSI deviceID detection In-Reply-To: <20251021124103.198419-6-lpieralisi@kernel.org> References: <20251021124103.198419-1-lpieralisi@kernel.org> <20251021124103.198419-6-lpieralisi@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Frank.Li@nxp.com, sascha.bischoff@arm.com, tglx@linutronix.de, robh@kernel.org, sbranden@broadcom.com, bhelgaas@google.com, rjui@broadcom.com, mani@kernel.org, kwilczynski@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 21 Oct 2025 13:41:03 +0100, Lorenzo Pieralisi wrote: > > Current code retrieving platform devices MSI devID in the GIC ITS MSI > parent helpers suffers from some minor issues: > > - It leaks a struct device_node reference > - It is duplicated between GICv3 and GICv5 for no good reason > - It does not use the OF phandle iterator code that simplifies > the msi-parent property parsing > > Consolidate GIC v3 and v5 deviceID retrieval in a function that addresses > the full set of issues in one go by merging GIC v3 and v5 code and > converting the msi-parent parsing loop to the more modern OF phandle > iterator API, fixing the struct device_node reference leak in the process. > > Signed-off-by: Lorenzo Pieralisi > Reviewed-by: Frank Li > Cc: Sascha Bischoff > Cc: Thomas Gleixner > Cc: Rob Herring > Cc: Frank Li > Cc: Marc Zyngier > --- > drivers/irqchip/irq-gic-its-msi-parent.c | 91 ++++++------------------ > 1 file changed, 23 insertions(+), 68 deletions(-) Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.