From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981D6C77B76 for ; Mon, 17 Apr 2023 16:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbjDQQjU (ORCPT ); Mon, 17 Apr 2023 12:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjDQQjT (ORCPT ); Mon, 17 Apr 2023 12:39:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58BBA8A59; Mon, 17 Apr 2023 09:39:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DAB1961E6C; Mon, 17 Apr 2023 16:39:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C1DCC433D2; Mon, 17 Apr 2023 16:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681749553; bh=cjNKKMHdrHO2WstsJosUdEUm+sLD/6tKUreVY2xuCjg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KdX1cd9ljXqYNZsfAbNsWfoSGDGQwRVAp7W3ZcCtdqzr3pGppXmB9Cfqm4m3qVlW2 443tmXPoreI6N8B808WkUW5fRXk8vftd/AoWRIAnYPIJNKiEl/F/C37o6msNVSXaf3 wsrtdEu2PpgD7Z+bAmNYuAnKQDEW90HVQEeu2m2Sml341AYOZrVnkecdu09OPVPOKG GSLmXZx4tjyvgTlT0FoGwSkyud43Heu5qQ33DWDYne2pCr3SJFzNMLBelL717LLv9L QlssVszIufxHY0OKo46qVWmPGsOO2qrpLvXYg+QXsiyVe/6Rj/ibTKg6vQCfeRrmbR FHsJ2g/Le3Yyw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poRsk-00956z-Pn; Mon, 17 Apr 2023 17:39:10 +0100 Date: Mon, 17 Apr 2023 17:39:10 +0100 Message-ID: <868reqlaz5.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Thomas Gleixner , Peng Fan , Robin Murphy , Peter Geis , XiaoDong Huang , Kever Yang , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: rk3588: add MSI support In-Reply-To: <20230417150038.51698-3-sebastian.reichel@collabora.com> References: <20230417150038.51698-1-sebastian.reichel@collabora.com> <20230417150038.51698-3-sebastian.reichel@collabora.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastian.reichel@collabora.com, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de, peng.fan@nxp.com, robin.murphy@arm.com, pgwipeout@gmail.com, derrick.huang@rock-chips.com, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 17 Apr 2023 16:00:38 +0100, Sebastian Reichel wrote: > > Add the two Interrupt Translation Service (ITS) IPs that are part of the > GIC-600, which are required for message signalled interrupts (MSI). This > is required for PCIe, which fully relies on MSI for interrupts. > > Enabling the ITS nodes requires an operating system, that has a > workaround for Rockchip errata #3588001 (GIC600 can not support > shareable attribute). $SUBJECT is inaccurate. This adds the descriptions of the ITSs, but doesn't wire any MSI support at all (nobody even refers these nodes, so the whole thing is pretty pointless). M. -- Without deviation from the norm, progress is not possible.