From: Heiko Stuebner <heiko@sntech.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
Date: Sat, 27 Jul 2019 17:33:38 +0200 [thread overview]
Message-ID: <86910491.m50tbimVMv@phil> (raw)
In-Reply-To: <20190727142736.23188-2-krzk@kernel.org>
Hi Krzysztof,
Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
> Fix DTC warning:
>
> arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
please see the comment directly above the memory node on why that needs
to stay that way. So no, we'll keep the veyron memory node as is.
Heiko
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 8fc8eac699bf..02243ff46a65 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -18,7 +18,7 @@
> * The default coreboot on veyron devices ignores memory@0 nodes
> * and would instead create another memory node.
> */
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x0 0x0 0x0 0x80000000>;
> };
>
next prev parent reply other threads:[~2019-07-27 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 14:27 [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Krzysztof Kozlowski
2019-07-27 14:27 ` [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron Krzysztof Kozlowski
2019-07-27 15:33 ` Heiko Stuebner [this message]
2019-07-28 11:38 ` Krzysztof Kozlowski
2019-07-28 20:55 ` Heiko Stuebner
2019-07-27 15:38 ` [PATCH 1/2] ARM: dts: rockchip: Cleanup style around assignment operator Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86910491.m50tbimVMv@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).