Devicetree
 help / color / mirror / Atom feed
From: Umang Chheda <umang.chheda@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	richardcochran@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi
Date: Tue, 12 May 2026 13:42:53 +0530	[thread overview]
Message-ID: <86976303-5f10-4643-be98-54e338471619@oss.qualcomm.com> (raw)
In-Reply-To: <e7c9b78f-f6ce-4f17-88e1-ee8e6620fef6@oss.qualcomm.com>



On 5/6/2026 2:48 PM, Konrad Dybcio wrote:
> On 5/5/26 3:53 PM, Umang Chheda wrote:
>> Hello Krzysztof,
>>
>> On 5/5/2026 1:49 AM, Krzysztof Kozlowski wrote:
>>> On 04/05/2026 14:57, Konrad Dybcio wrote:
>>>> On 4/27/26 7:05 PM, Umang Chheda wrote:
>>>>> The monaco-ac EVK is a new board variant which shares the majority of
>>>>> its hardware description with the existing monaco-evk board.
>>>>>
>>>>> In preparation for adding this variant, extract the common hardware
>>>>> nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
>>>>> include file, and update monaco-evk.dts to include it and keep only
>>>>> board-specific overrides.
>>>>>
>>>>> No functional change intended.
>>>>>
>>>>> Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
>>>>> ---
>>>>
>>>> The patch is a bit difficult to view as-is, but the gist of it is that
>>>> the resulting monaco-evk.dts is:
>>>
>>> Diff should be fixed and since this is not even b4, than producing
>>> proper patch detecting rename is trivial. :/
>>
>> I acknowledge it's hard to review the patch this way.
>>
>> I’ll rework the patch to use a proper rename (git mv) and keep the
>> follow-up changes minimal, so the diff cleanly shows the extraction into
>> monaco-evk-common.dtsi.
> 
> Try adding this hunk to your gitconfig:
> 
> [diff]
>         renameLimit = 999999
>         algorithm = histogram # or patience
>         renames = copies


Thanks Konrad for the inputs, will add this and re-send the patch.

> 
> 
> Konrad


  reply	other threads:[~2026-05-12  8:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 17:05 [PATCH v4 0/4] arm64: dts: qcom: Introduce support for monaco-ac-evk Umang Chheda
2026-04-27 17:05 ` [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi Umang Chheda
2026-05-04 12:57   ` Konrad Dybcio
2026-05-04 18:28     ` Umang Chheda
2026-05-04 20:19     ` Krzysztof Kozlowski
2026-05-05 13:53       ` Umang Chheda
2026-05-06  9:18         ` Konrad Dybcio
2026-05-12  8:12           ` Umang Chheda [this message]
2026-05-04 18:44   ` Dmitry Baryshkov
2026-05-04 19:26     ` Umang Chheda
2026-05-04 23:28       ` Dmitry Baryshkov
2026-05-05 13:47         ` Umang Chheda
2026-04-27 17:05 ` [PATCH v4 2/4] dt-bindings: arm: qcom: Add monaco-ac-evk support Umang Chheda
2026-04-27 17:05 ` [PATCH v4 3/4] arm64: dts: qcom: monaco: Add monaco-ac EVK board Umang Chheda
2026-05-04 12:53   ` Konrad Dybcio
2026-05-04 19:16     ` Umang Chheda
2026-05-06  9:17       ` Konrad Dybcio
2026-04-27 17:05 ` [PATCH v4 4/4] arm64: dts: qcom: monaco-ac-evk: Add IFP mezzanine Umang Chheda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86976303-5f10-4643-be98-54e338471619@oss.qualcomm.com \
    --to=umang.chheda@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox