From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBEC3947AE; Tue, 7 Jul 2026 09:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783416357; cv=none; b=sLeW5TIKf8lC9fdG0BreSTByHR2+2jR9Gkt342yKvFnQ4t/d64jyqv3q++4vFov0SZH73PLcpY4uNO1jCyJNZkWoNnG33wsOc9/L43FGCYYUzMgRyCuGdNC77//nYkgrQslX4DNl7/OJemlSEHebfNfzRQFwyN0t/k0NkMPyRBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783416357; c=relaxed/simple; bh=NZ9lzvP57Ud4WiitzvkiRYtgFXcEGoXdNtl7wfwuFSs=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=VuKEZJi271dVvBXeLSfnmdRKFRDCxjHUBBhc8wVzwzoy23Iriyht+lyuWJGPbIs1jfdfWvRUQ/CtibJfu6traFkX/FrGocdLqD1GaXMapJt1TLfDSchciPBLrOTLqML5db2IOiJ3nqwe4PD0Cgc7hscXuF+ixExVHE6f3dxHI90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KnruRaKf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KnruRaKf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46DD81F00A3A; Tue, 7 Jul 2026 09:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783416356; bh=8uyo2XhmUAHRevNoXiCaMuL1oCl90zKZlPv2wkcpU7o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KnruRaKfHD+xT3Z4ZkAXPUYtv1S3SziqmpW11MvmgPrTZpKhaJ4eZBaCpwBva3NlE U56oUy52tboS0xyFp0xbs1VISvI8UKsGhcn/gFg918a866mC/j6Hnt+A6WkYs6nNWu zb5i2h4IFEvbs4gkpVB1aXWqAyIWT37DdANxvPtIkTmA3DhEcr844iujUcGgrBwCuz L1hIcxQ7ix5RzOIa/AXDe71lufSEIu2OKlMSjbGMJapa4lC/Y2LPCczTiyxDfTxR0l zSqmQ+5iIvVbO+clviVV+mv8bQ+OPJ5i3zmuSuXda0la8rc9hHEGEEIjjPVIF5oRX+ DFUrHA8rGpsAg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wh23u-00000002KZJ-0bdk; Tue, 07 Jul 2026 09:25:54 +0000 Date: Tue, 07 Jul 2026 10:25:53 +0100 Message-ID: <86a4s3p2vy.wl-maz@kernel.org> From: Marc Zyngier To: Yureka Lilian Cc: Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2ls?= =?UTF-8?B?Y3p5xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Sven Peter , Janne Grunau , Neal Gompa , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: apple: Integrate pwrctrl API In-Reply-To: <20260707-apple-pcie-pwren-v1-1-5a281b182fe2@cyberchaos.dev> References: <20260707-apple-pcie-pwren-v1-0-5a281b182fe2@cyberchaos.dev> <20260707-apple-pcie-pwren-v1-1-5a281b182fe2@cyberchaos.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yureka@cyberchaos.dev, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, sven@kernel.org, j@jannau.net, neal@gompa.dev, krzk+dt@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 06 Jul 2026 23:38:27 +0100, Yureka Lilian wrote: > > Integrate the PCI pwrctrl framework into the Apple PCIe host driver to > provide standardized power management for PCI devices. > > Notably, this allows enabling powering on the WiFi, SD card reader on > various Macs by means of the pwrctrl framework before probing the ports. > > Previously, a custom solution for powering on the WiFi and SD card > reader was proposed[1], but we can now use the new pci-pwrctrl-generic > driver for this purpose. > > Link[1]: https://lore.kernel.org/lkml/20220502093832.32778-4-marcan@marcan.st/ > nit: this paragraph and the accompanying link don't belong in the commit message and should be moved below the --- mark or even better, to the cover letter. > Signed-off-by: Yureka Lilian > --- > drivers/pci/controller/Kconfig | 1 + > drivers/pci/controller/pcie-apple.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 2247709ef6d6..af64630d28fa 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -46,6 +46,7 @@ config PCIE_APPLE > depends on OF > depends on PCI_MSI > select PCI_HOST_COMMON > + select PCI_PWRCTRL_GENERIC > select IRQ_MSI_LIB > help > Say Y here if you want to enable PCIe controller support on Apple > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index c2cffc0659f4..db038a9d4831 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include "pci-host-common.h" > > @@ -825,6 +826,21 @@ static int apple_pcie_init(struct pci_config_window *cfg) > if (WARN_ON(!pcie)) > return -ENOENT; > > + ret = pci_pwrctrl_create_devices(pcie->dev); > + if (ret) { > + dev_err(pcie->dev, "Failed to create pwrctrl devices: %pe\n", ret); > + return ret; > + } > + > + ret = pci_pwrctrl_power_on_devices(pcie->dev); > + if (ret) { > + if (ret != -EPROBE_DEFER) { > + dev_err(pcie->dev, "Failed to power on devices: %pe\n", ret); > + pci_pwrctrl_destroy_devices(pcie->dev); > + } > + return ret; > + } > + Why is this done globally while the whole driver works on a per-port basis, and that the proposed DT updates are also per port? Thanks, M. -- Without deviation from the norm, progress is not possible.