From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8650: add iris DT node
Date: Thu, 24 Apr 2025 15:37:11 +0200 [thread overview]
Message-ID: <86a641e1-4526-411d-b218-7f770ee949d7@kernel.org> (raw)
In-Reply-To: <asfwnyn5grm426vq5qatrxfffv3wmbuzx6266rblanzqepffzx@7773dcxfaqe4>
On 19/04/2025 01:05, Dmitry Baryshkov wrote:
> On Fri, Apr 18, 2025 at 03:20:35PM +0200, Neil Armstrong wrote:
>> Add DT entries for the sm8650 iris decoder.
>>
>> Since the firmware is required to be signed, only enable
>> on Qualcomm development boards where the firmware is
>> available.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 5 ++
>> arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 5 ++
>> arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 5 ++
>
> I'd say that these are 4 commits.
Why? It's simple and easy to review in one commit as well. This is
really nitpicking.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-24 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 13:20 [PATCH] arm64: dts: qcom: sm8650: add iris DT node Neil Armstrong
2025-04-18 23:05 ` Dmitry Baryshkov
2025-04-22 7:07 ` Neil Armstrong
2025-04-24 11:17 ` Dmitry Baryshkov
2025-04-24 12:43 ` Neil Armstrong
2025-04-24 14:24 ` Dmitry Baryshkov
2025-04-24 13:37 ` Krzysztof Kozlowski [this message]
2025-04-21 15:07 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a641e1-4526-411d-b218-7f770ee949d7@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).