* [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00
@ 2024-08-26 20:53 Frank Li
2024-08-26 20:53 ` [PATCH 2/3] arm64: dts: imx93-11x11-evk: add flexcan support Frank Li
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Frank Li @ 2024-08-26 20:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Add io-expander adi,adp5585 under lpi2c2 and lpi2c3.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../boot/dts/freescale/imx93-11x11-evk.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 60eb64761392e..7629b6b44aa43 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -302,6 +302,16 @@ ldo5: LDO5 {
};
};
};
+
+ adp5585gpio: io-expander@34 {
+ compatible = "adi,adp5585-00", "adi,adp5585";
+ reg = <0x34>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-reserved-ranges = <5 1>;
+ #pwm-cells = <3>;
+ };
+
};
&lpi2c3 {
@@ -310,6 +320,14 @@ &lpi2c3 {
pinctrl-0 = <&pinctrl_lpi2c3>;
status = "okay";
+ adp5585_isp: io-expander@34 {
+ compatible = "adi,adp5585-01", "adi,adp5585";
+ reg = <0x34>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ #pwm-cells = <3>;
+ };
+
ptn5110: tcpc@50 {
compatible = "nxp,ptn5110", "tcpci";
reg = <0x50>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] arm64: dts: imx93-11x11-evk: add flexcan support
2024-08-26 20:53 [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
@ 2024-08-26 20:53 ` Frank Li
2024-08-26 20:53 ` [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card Frank Li
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2024-08-26 20:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
From: Haibo Chen <haibo.chen@nxp.com>
Add flexcan support.
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../boot/dts/freescale/imx93-11x11-evk.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 7629b6b44aa43..f20d281531734 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -69,6 +69,14 @@ reg_vref_1v8: regulator-adc-vref {
regulator-max-microvolt = <1800000>;
};
+ reg_can2_standby: regulator-can2-standby {
+ compatible = "regulator-fixed";
+ regulator-name = "can2-stby";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&adp5585gpio 6 GPIO_ACTIVE_LOW>;
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -196,6 +204,13 @@ ethphy2: ethernet-phy@2 {
};
};
+&flexcan2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexcan2>;
+ xceiver-supply = <®_can2_standby>;
+ status = "okay";
+};
+
&lpi2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
@@ -602,6 +617,13 @@ MX93_PAD_ENET2_TX_CTL__GPIO4_IO20 0x51e
>;
};
+ pinctrl_flexcan2: flexcan2grp {
+ fsl,pins = <
+ MX93_PAD_GPIO_IO25__CAN2_TX 0x139e
+ MX93_PAD_GPIO_IO27__CAN2_RX 0x139e
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX93_PAD_UART1_RXD__LPUART1_RX 0x31e
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card
2024-08-26 20:53 [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
2024-08-26 20:53 ` [PATCH 2/3] arm64: dts: imx93-11x11-evk: add flexcan support Frank Li
@ 2024-08-26 20:53 ` Frank Li
2024-08-27 13:27 ` Krzysztof Kozlowski
2024-08-26 20:59 ` [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
2024-08-27 12:31 ` Rob Herring (Arm)
3 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2024-08-26 20:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
From: Chancel Liu <chancel.liu@nxp.com>
Add wm8962 sound card which connects to sai3.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../boot/dts/freescale/imx93-11x11-evk.dts | 78 +++++++++++++++++++
1 file changed, 78 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index f20d281531734..65ed861d67d7c 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -69,6 +69,15 @@ reg_vref_1v8: regulator-adc-vref {
regulator-max-microvolt = <1800000>;
};
+ reg_audio_pwr: regulator-audio-pwr {
+ compatible = "regulator-fixed";
+ regulator-name = "audio-pwr";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&adp5585gpio 1 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
reg_can2_standby: regulator-can2-standby {
compatible = "regulator-fixed";
regulator-name = "can2-stby";
@@ -127,6 +136,22 @@ cpu {
};
};
+ sound-wm8962 {
+ compatible = "fsl,imx-audio-wm8962";
+ model = "wm8962-audio";
+ audio-cpu = <&sai3>;
+ audio-codec = <&wm8962>;
+ hp-det-gpio = <&pcal6524 4 GPIO_ACTIVE_HIGH>;
+ audio-routing =
+ "Headphone Jack", "HPOUTL",
+ "Headphone Jack", "HPOUTR",
+ "Ext Spk", "SPKOUTL",
+ "Ext Spk", "SPKOUTR",
+ "AMIC", "MICBIAS",
+ "IN3R", "AMIC",
+ "IN1R", "AMIC";
+ };
+
sound-xcvr {
compatible = "fsl,imx-audio-card";
model = "imx-audio-xcvr";
@@ -217,6 +242,28 @@ &lpi2c1 {
pinctrl-0 = <&pinctrl_lpi2c1>;
status = "okay";
+ wm8962: codec@1a {
+ compatible = "wlf,wm8962";
+ reg = <0x1a>;
+ clocks = <&clk IMX93_CLK_SAI3_GATE>;
+ DCVDD-supply = <®_audio_pwr>;
+ DBVDD-supply = <®_audio_pwr>;
+ AVDD-supply = <®_audio_pwr>;
+ CPVDD-supply = <®_audio_pwr>;
+ MICVDD-supply = <®_audio_pwr>;
+ PLLVDD-supply = <®_audio_pwr>;
+ SPKVDD1-supply = <®_audio_pwr>;
+ SPKVDD2-supply = <®_audio_pwr>;
+ gpio-cfg = <
+ 0x0000 /* 0:Default */
+ 0x0000 /* 1:Default */
+ 0x0000 /* 2:FN_DMICCLK */
+ 0x0000 /* 3:Default */
+ 0x0000 /* 4:FN_DMICCDAT */
+ 0x0000 /* 5:Default */
+ >;
+ };
+
inertial-meter@6a {
compatible = "st,lsm6dso";
reg = <0x6a>;
@@ -458,6 +505,17 @@ &sai1 {
status = "okay";
};
+&sai3 {
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&pinctrl_sai3>;
+ pinctrl-1 = <&pinctrl_sai3_sleep>;
+ assigned-clocks = <&clk IMX93_CLK_SAI3>;
+ assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
+ assigned-clock-rates = <12288000>;
+ fsl,sai-mclk-direction-output;
+ status = "okay";
+};
+
&usbotg1 {
dr_mode = "otg";
hnp-disable;
@@ -758,6 +816,26 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07 0x31e
>;
};
+ pinctrl_sai3: sai3grp {
+ fsl,pins = <
+ MX93_PAD_GPIO_IO26__SAI3_TX_SYNC 0x31e
+ MX93_PAD_GPIO_IO16__SAI3_TX_BCLK 0x31e
+ MX93_PAD_GPIO_IO17__SAI3_MCLK 0x31e
+ MX93_PAD_GPIO_IO19__SAI3_TX_DATA00 0x31e
+ MX93_PAD_GPIO_IO20__SAI3_RX_DATA00 0x31e
+ >;
+ };
+
+ pinctrl_sai3_sleep: sai3grpsleep {
+ fsl,pins = <
+ MX93_PAD_GPIO_IO26__GPIO2_IO26 0x51e
+ MX93_PAD_GPIO_IO16__GPIO2_IO16 0x51e
+ MX93_PAD_GPIO_IO17__GPIO2_IO17 0x51e
+ MX93_PAD_GPIO_IO19__GPIO2_IO19 0x51e
+ MX93_PAD_GPIO_IO20__GPIO2_IO20 0x51e
+ >;
+ };
+
pinctrl_spdif: spdifgrp {
fsl,pins = <
MX93_PAD_GPIO_IO22__SPDIF_IN 0x31e
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00
2024-08-26 20:53 [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
2024-08-26 20:53 ` [PATCH 2/3] arm64: dts: imx93-11x11-evk: add flexcan support Frank Li
2024-08-26 20:53 ` [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card Frank Li
@ 2024-08-26 20:59 ` Frank Li
2024-08-27 12:31 ` Rob Herring (Arm)
3 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2024-08-26 20:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, Aug 26, 2024 at 04:53:32PM -0400, Frank Li wrote:
> Add io-expander adi,adp5585 under lpi2c2 and lpi2c3.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
I forget mentions adi,adp5585 binding and driver already in linux-next
tree.
Frank
> .../boot/dts/freescale/imx93-11x11-evk.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 60eb64761392e..7629b6b44aa43 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -302,6 +302,16 @@ ldo5: LDO5 {
> };
> };
> };
> +
> + adp5585gpio: io-expander@34 {
> + compatible = "adi,adp5585-00", "adi,adp5585";
> + reg = <0x34>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-reserved-ranges = <5 1>;
> + #pwm-cells = <3>;
> + };
> +
> };
>
> &lpi2c3 {
> @@ -310,6 +320,14 @@ &lpi2c3 {
> pinctrl-0 = <&pinctrl_lpi2c3>;
> status = "okay";
>
> + adp5585_isp: io-expander@34 {
> + compatible = "adi,adp5585-01", "adi,adp5585";
> + reg = <0x34>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + #pwm-cells = <3>;
> + };
> +
> ptn5110: tcpc@50 {
> compatible = "nxp,ptn5110", "tcpci";
> reg = <0x50>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00
2024-08-26 20:53 [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
` (2 preceding siblings ...)
2024-08-26 20:59 ` [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
@ 2024-08-27 12:31 ` Rob Herring (Arm)
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-08-27 12:31 UTC (permalink / raw)
To: Frank Li
Cc: devicetree, Shawn Guo, imx, Pengutronix Kernel Team,
linux-arm-kernel, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
linux-kernel, Fabio Estevam
On Mon, 26 Aug 2024 16:53:32 -0400, Frank Li wrote:
> Add io-expander adi,adp5585 under lpi2c2 and lpi2c3.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../boot/dts/freescale/imx93-11x11-evk.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb' for 20240826205334.975272-1-Frank.Li@nxp.com:
arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: pinctrl@443c0000: 'sai3grpsleep' does not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/fsl,imx9-pinctrl.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card
2024-08-26 20:53 ` [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card Frank Li
@ 2024-08-27 13:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-27 13:27 UTC (permalink / raw)
To: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On 26/08/2024 22:53, Frank Li wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Add wm8962 sound card which connects to sai3.
...
> +
> &usbotg1 {
> dr_mode = "otg";
> hnp-disable;
> @@ -758,6 +816,26 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07 0x31e
> >;
> };
>
> + pinctrl_sai3: sai3grp {
> + fsl,pins = <
> + MX93_PAD_GPIO_IO26__SAI3_TX_SYNC 0x31e
> + MX93_PAD_GPIO_IO16__SAI3_TX_BCLK 0x31e
> + MX93_PAD_GPIO_IO17__SAI3_MCLK 0x31e
> + MX93_PAD_GPIO_IO19__SAI3_TX_DATA00 0x31e
> + MX93_PAD_GPIO_IO20__SAI3_RX_DATA00 0x31e
> + >;
> + };
> +
> + pinctrl_sai3_sleep: sai3grpsleep {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-27 13:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 20:53 [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
2024-08-26 20:53 ` [PATCH 2/3] arm64: dts: imx93-11x11-evk: add flexcan support Frank Li
2024-08-26 20:53 ` [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card Frank Li
2024-08-27 13:27 ` Krzysztof Kozlowski
2024-08-26 20:59 ` [PATCH 1/3] arm64: dts: imx93-11x11-evk: add io-expander adi,adp5585-00 Frank Li
2024-08-27 12:31 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).