Re: [PATCH v2 1/3] dt-bindings: hwmon: Document SMSC EMC1402/1403/1404/1428

[Guenter Roeck <linux@roeck-us.net>]

On 6/19/26 03:40, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The device tree binding schema fails to correctly restrict the maximum number of channels for the `smsc,emc1402` and its variants (emc1412, emc1422, emc1442). By grouping it alongside `emc1403` under the `not` condition for `emc1404`/`emc1428`, it inadvertently sets the channel `reg` maximum to 2 instead of 1.
> --
> 
> commit 5a834c50ed998e304e4c00fb64e4e434cbd93896
> Author: Svyatoslav Ryhel <clamor95@gmail.com>
> 
> dt-bindings: hwmon: Document SMSC EMC1402/1403/1404/1428
> 
> This commit documents the basic hardware layout of SMSC (now Microchip)
> EMC1402/1403/1404/1428 thermal sensors.
> 
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/smsc,emc1403.yaml
> 
> [ ... ]
> 
>> +allOf:
>> +  - if:
>> +      not:
>> +        properties:
>> +          compatible:
>> +            contains:
>> +              enum:
>> +                - smsc,emc1404
>> +                - smsc,emc1428
>> +    then:
>> +      patternProperties:
>> +        "^channel@([0-7])$":
>> +          properties:
>> +            reg:
>> +              items:
>> +                maximum: 2
> 
> [Severity: Low]
> Does this conditional block correctly restrict the channel limits for the
> smsc,emc1402 device and its variants (emc1412, emc1422, emc1442)?
> 
> By grouping the emc1402 variants with the emc1403 under the fallback
> condition (not containing emc1404/emc1428), it applies a maximum reg value
> of 2. This appears to allow up to 3 channels (0, 1, 2) to pass schema
> validation.
> 
> Since the emc1402 hardware only supports 2 channels (local and 1 remote),
> should there be a separate conditional for the emc1402 family setting the
> maximum to 1?
> 

I am by no means a devicetree expert, but it seems to me that Sashiko
has a point. Please take a look.

Thanks,
Guenter