From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C0CC0015E for ; Wed, 19 Jul 2023 08:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbjGSI7I (ORCPT ); Wed, 19 Jul 2023 04:59:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjGSI7H (ORCPT ); Wed, 19 Jul 2023 04:59:07 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B17DB186 for ; Wed, 19 Jul 2023 01:59:05 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4faaaa476a9so11255251e87.2 for ; Wed, 19 Jul 2023 01:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689757144; x=1692349144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WjwZwXCwXmQM2M0w+HMY5U9URq0w0O8JkoEEEKtmHuY=; b=WBCaZgcOMjA+k/QpkjJGCnd/b5G/48llJV9HxfVW2Dtqpe8UAevu5A+dKDqe/PoJMu tS08s2b/y1eUfvbbtsJhiLe9z0hUaTiPJxiJDaJTbMz9KZ83kh7pXaSLdPkB5H8Ozlhv MvnARJkhm/LOEAyr90a84nmSdtClE+bCi+1SDdIe1Eyq11qLmu9QkUpELJBpV23EqHZJ Ks4XrMTY49SaSGJr9/Y1TYv0siRRGVrG0rp6RcceZUq6OWpdV7TinyvCiEWNIFFwno8C ThPzLbTfPADRjOtV9VhD6vaAtU3BgdKp4wZ5GPxz1fID+rikEcpkxkh7/xjNwnVpztD8 yztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689757144; x=1692349144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WjwZwXCwXmQM2M0w+HMY5U9URq0w0O8JkoEEEKtmHuY=; b=EH3wGECv9ZouvHp4wyyEk97rT6XNmvym/QyEp8BXv3Cgl6Bvg7AXFa59Oy1RIvWzGO JBSRSjKSxiJFiZUW9Bq8BR6f39MteOmuS01oueyWWoA4m5146xsGIWtT+savE6GhyzGS arsh8A873qzaho12ndv90enWeE0me1s2huXu8WZgkMjH9nnQAqKvCD3QQQAsRqUdb0B5 XtpOQXMNoe3FasabXBvN8GyM3joaRthl1rjfeLVHALSx4iJ3uAjNnfmFXlq5STLgIuH3 xHpqiOayn6Ym94iPQPYw+V43FG33PyLeKRxsO/nLh0EzuCkXXYsOl+xMRx+6L07rgPOr JLEg== X-Gm-Message-State: ABy/qLaxnZ7RxikndOi6SQhS+ebQvoryDGabqyc+PQjeijeC/xxchfxN 3PxPfUeEHo/TBFad1rIZvF5LoA== X-Google-Smtp-Source: APBJJlG145+baYy2xRG5EFByw1fAnzYogqFOqfQMF9/Kcfbqlu51ky4jNieZhAvomXVs9haaW6JG7g== X-Received: by 2002:a05:6512:1089:b0:4fb:89e3:5ac6 with SMTP id j9-20020a056512108900b004fb89e35ac6mr13736198lfg.62.1689757144005; Wed, 19 Jul 2023 01:59:04 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id h5-20020a50ed85000000b00521a7864e13sm2306858edr.90.2023.07.19.01.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 01:59:03 -0700 (PDT) Message-ID: <86cbedcd-692b-ecb8-2075-d50835739bcf@linaro.org> Date: Wed, 19 Jul 2023 10:59:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg" Content-Language: en-US To: "Li, Meng" , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "dinguyen@kernel.org" , "hminas@synopsys.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" Cc: "linux-kernel@vger.kernel.org" References: <20230719025509.3007986-1-Meng.Li@windriver.com> <20230719025509.3007986-4-Meng.Li@windriver.com> <488835c0-e08e-c0cc-abac-192f658b093f@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/07/2023 10:45, Li, Meng wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Wednesday, July 19, 2023 2:39 PM >> To: Li, Meng ; gregkh@linuxfoundation.org; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> dinguyen@kernel.org; hminas@synopsys.com; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga- >> stratix10-hsotg" >> >> CAUTION: This email comes from a non Wind River email account! >> Do not click links or open attachments unless you recognize the sender and >> know the content is safe. >> >> On 19/07/2023 04:55, Meng Li wrote: >>> Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2 >>> implementation, because the Stratix DWC2 implementation does not >>> support clock gating. This compatible is used with generic snps,dwc2. >>> >>> Signed-off-by: Meng Li >> >> Missing changelog, missing versioning. This is v3 or v4. >> >>> --- >>> Documentation/devicetree/bindings/usb/dwc2.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml >>> b/Documentation/devicetree/bindings/usb/dwc2.yaml >>> index dc4988c0009c..f90094320914 100644 >>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml >>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml >>> @@ -51,6 +51,7 @@ properties: >>> - amlogic,meson-g12a-usb >>> - amlogic,meson-a1-usb >>> - intel,socfpga-agilex-hsotg >>> + - intel,socfpga-stratix10-hsotg >> >> So you just sent the same patch as before. I pointed you to the proper solution >> with compatibility. >> > > No. not the same. > I don't understand why SoC specific compatible "intel,socfpga-agilex-hsotg" is able to be added, but the SoC specific compatible "intel,socfpga-stratix10-hsotg" is not allowed. > > You said "Where is SoC specific compatible?" > Now, I add the SoC specific compatible "intel,socfpga-stratix10-hsotg", but why it is still not reasonable. The compatible should be added, but I said they are compatible, so express it. I also gave you example of file which expresses it. Why that compatible is not allowed alone? Because what we said here many, many times and because the doc I gave you which explains this. Best regards, Krzysztof