From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rayyan Ansari <rayyan.ansari@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node
Date: Tue, 23 Jul 2024 00:46:06 +0200 [thread overview]
Message-ID: <86cf4781-ce66-48a4-b5a6-4b72ed76c65d@linaro.org> (raw)
In-Reply-To: <20240722-pmic-bindings-v1-2-555942b3c4e1@linaro.org>
On 22.07.2024 1:47 PM, Rayyan Ansari wrote:
> Remove the address in both the reg property and node name, as it is
> hardcoded in the driver, meaning it is unneeded.
>
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---
Well the bindings are opaque to the implementation, and the commit
message could reference adhering to those instead
The contents are fine
next prev parent reply other threads:[~2024-07-22 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 11:47 [PATCH 0/3] arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml Rayyan Ansari
2024-07-22 11:47 ` [PATCH 1/3] arm64: dts: qcom: pmi8994: Add label to wled node Rayyan Ansari
2024-07-22 22:44 ` Konrad Dybcio
2024-07-22 11:47 ` [PATCH 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node Rayyan Ansari
2024-07-22 22:46 ` Konrad Dybcio [this message]
2024-07-22 11:47 ` [PATCH 3/3] ARM: dts: qcom: pma8084: add pon node Rayyan Ansari
2024-07-22 22:47 ` Konrad Dybcio
2024-07-23 11:35 ` Dmitry Baryshkov
2024-07-23 11:39 ` Konrad Dybcio
2024-07-23 11:45 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cf4781-ce66-48a4-b5a6-4b72ed76c65d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayyan.ansari@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).