devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi
@ 2020-11-24 22:59 Icenowy Zheng
  2020-11-24 23:30 ` Icenowy Zheng
  0 siblings, 1 reply; 2+ messages in thread
From: Icenowy Zheng @ 2020-11-24 22:59 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi,
	Icenowy Zheng

The PineCube board has a RTL8189ES Wi-Fi module on board, and the module
doesn't have any MAC address programmed in.

Add a ethernet alias in the DT, thus the bootloader will then be able to
generate a MAC address into the device tree node of Wi-Fi.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm/boot/dts/sun8i-s3-pinecube.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
index 4aa0ee897a0a..5086f713467a 100644
--- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
+++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
@@ -13,6 +13,7 @@ / {
 	compatible = "pine64,pinecube", "sochip,s3", "allwinner,sun8i-v3";
 
 	aliases {
+		ethernet0 = &rtl8189es;
 		serial0 = &uart2;
 	};
 
@@ -156,6 +157,10 @@ &mmc1 {
 	bus-width = <4>;
 	non-removable;
 	status = "okay";
+
+	rtl8189es: wifi@1 {
+		reg = <1>;
+	};
 };
 
 &pio {
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi
  2020-11-24 22:59 [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi Icenowy Zheng
@ 2020-11-24 23:30 ` Icenowy Zheng
  0 siblings, 0 replies; 2+ messages in thread
From: Icenowy Zheng @ 2020-11-24 23:30 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi

在 2020-11-25星期三的 06:59 +0800,Icenowy Zheng写道:
> The PineCube board has a RTL8189ES Wi-Fi module on board, and the
> module
> doesn't have any MAC address programmed in.

Sorry, but now I'm unsure about this.

The module seems to have MAC address programmed.

> 
> Add a ethernet alias in the DT, thus the bootloader will then be able
> to
> generate a MAC address into the device tree node of Wi-Fi.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/boot/dts/sun8i-s3-pinecube.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> index 4aa0ee897a0a..5086f713467a 100644
> --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> @@ -13,6 +13,7 @@ / {
>  	compatible = "pine64,pinecube", "sochip,s3", "allwinner,sun8i-
> v3";
>  
>  	aliases {
> +		ethernet0 = &rtl8189es;
>  		serial0 = &uart2;
>  	};
>  
> @@ -156,6 +157,10 @@ &mmc1 {
>  	bus-width = <4>;
>  	non-removable;
>  	status = "okay";
> +
> +	rtl8189es: wifi@1 {
> +		reg = <1>;
> +	};
>  };
>  
>  &pio {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-24 23:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24 22:59 [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi Icenowy Zheng
2020-11-24 23:30 ` Icenowy Zheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).