From: Marc Zyngier <maz@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Sneh Mankad <sneh.mankad@oss.qualcomm.com>,
Ulf Hansson <ulf.hansson@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: interrupt-controller: mpm: Document power-domains property
Date: Wed, 15 Jul 2026 09:54:34 +0100 [thread overview]
Message-ID: <86cxwoocol.wl-maz@kernel.org> (raw)
In-Reply-To: <3dac25b9-a464-4350-aff5-0ada4dc1d65e@samsung.com>
On Wed, 15 Jul 2026 07:38:59 +0100,
Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> On 13.07.2026 17:11, Marc Zyngier wrote:
> > On Mon, 13 Jul 2026 11:25:41 +0100,
> > Sneh Mankad <sneh.mankad@oss.qualcomm.com> wrote:
> >> Remove #power-domain-cells property and add power-domains property for
> >> MPM device.
> >>
> >> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
> >> ---
> >> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> >> index ebb40c48950ab3a8fc86f5708acfc33c33d68993..3f9645fbc3c20633077aaa589e5d5a43928dab51 100644
> >> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> >> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> >> @@ -68,8 +68,8 @@ properties:
> >> - description: MPM pin number
> >> - description: GIC SPI number for the MPM pin
> >>
> >> - '#power-domain-cells':
> >> - const: 0
> >> + power-domains:
> >> + maxItems: 1
> > What makes you think it is OK to change an existing binding in an
> > incompatible way?
>
>
> Ulf suggests that this has been modeled upside down in the initial
> submission:
>
> https://lore.kernel.org/all/CAPx+jO9d1qH12mxg-n1rkbp6Xd__sdrSMeoc7CPELE+jgxRYHA@mail.gmail.com/
Sure. We have collectively fucked up a lot of bindings over the years,
mostly because of the lack of accurate documentation and people not
giving a damn about the correctness of these descriptions. I'm glad
that Ulf is now able to make it right.
But that is not a license to invalidate DTs retrospectively. We don't
update DTs in lockstep with the kernel (I *never* do), and something
that existed must be supported in the long run.
Properties can be deprecated, but:
- they must be kept in the binding
- drivers must still honor them if they are present in the DT
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2026-07-15 8:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 10:25 [PATCH 0/7] Register MPM under CPU cluster power domain to manage RPM notification Sneh Mankad
2026-07-13 10:25 ` [PATCH 1/7] dt-bindings: interrupt-controller: mpm: Document power-domains property Sneh Mankad
2026-07-13 10:36 ` sashiko-bot
2026-07-13 11:26 ` Konrad Dybcio
2026-07-13 15:11 ` Marc Zyngier
2026-07-15 6:38 ` Marek Szyprowski
2026-07-15 8:54 ` Marc Zyngier [this message]
2026-07-13 10:25 ` [PATCH 2/7] irqchip/irq-qcom-mpm: Register MPM under CPU cluster power domain Sneh Mankad
2026-07-13 10:41 ` sashiko-bot
2026-07-15 9:46 ` Konrad Dybcio
2026-07-15 10:34 ` Stephan Gerhold
2026-07-15 10:45 ` Konrad Dybcio
2026-07-15 10:49 ` Stephan Gerhold
2026-07-15 11:11 ` Konrad Dybcio
2026-07-13 10:25 ` [PATCH 3/7] irqchip/irq-qcom-mpm: Prepare common access path for timer and pin regs Sneh Mankad
2026-07-13 10:39 ` sashiko-bot
2026-07-15 9:59 ` Konrad Dybcio
2026-07-13 10:25 ` [PATCH 4/7] irqchip/irq-qcom-mpm: Program wakeup timer when CPU cluster goes to LPM Sneh Mankad
2026-07-13 10:38 ` sashiko-bot
2026-07-13 15:18 ` Marc Zyngier
2026-07-13 10:25 ` [PATCH 5/7] arm64: dts: qcom: sm6375: Make MPM device as part of CPU cluster domain Sneh Mankad
2026-07-13 10:40 ` sashiko-bot
2026-07-13 10:25 ` [PATCH 6/7] arm64: dts: qcom: agatti: Do not mark MPM as power domain Sneh Mankad
2026-07-13 10:39 ` sashiko-bot
2026-07-15 10:01 ` Konrad Dybcio
2026-07-13 10:25 ` [PATCH 7/7] arm64: dts: qcom: shikra: Add CPU idle states Sneh Mankad
2026-07-15 10:02 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cxwoocol.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sneh.mankad@oss.qualcomm.com \
--cc=tglx@kernel.org \
--cc=ulf.hansson@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox