From: Marc Zyngier <maz@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: tglx@linutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
youlin.pei@mediatek.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array
Date: Wed, 23 Nov 2022 16:28:08 +0000 [thread overview]
Message-ID: <86cz9doctj.wl-maz@kernel.org> (raw)
In-Reply-To: <c8174977-2995-811a-83e2-9f941057acd8@collabora.com>
On Wed, 23 Nov 2022 14:57:02 +0000,
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:
>
> >> + enum mtk_cirq_reg_index idx,
> >> + unsigned int cirq_num)
> >
> > What does cirq_num mean for registers that are not relative to an
> > interrupt? Create a separate helper for those.
> >
> Means literally nothing, so yes I agree, but...
>
> ... mtk_cirq_irq_reg(), mtk_cirq_reg() feels too similar and may lead to
> confusion while reading the code.
>
> Any advice about a possibly clear-er name?
I think the names are OK. Passing an interrupt number as a parameter
is a good discriminant anyway.
Please wait for a few days before posting the next version though.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-11-23 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 11:22 [PATCH v2 0/4] MediaTek CIRQ: new register layout and schema AngeloGioacchino Del Regno
2022-11-23 11:22 ` [PATCH v2 1/4] dt-bindings: interrupt-controller: mediatek,cirq: Migrate to dt schema AngeloGioacchino Del Regno
2022-11-23 14:21 ` Krzysztof Kozlowski
2022-11-23 11:22 ` [PATCH v2 2/4] dt-bindings: interrupt-controller: mediatek,cirq: Document MT8192 AngeloGioacchino Del Regno
2022-11-23 11:22 ` [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array AngeloGioacchino Del Regno
2022-11-23 13:50 ` Marc Zyngier
2022-11-23 14:57 ` AngeloGioacchino Del Regno
2022-11-23 16:28 ` Marc Zyngier [this message]
2022-11-24 9:59 ` AngeloGioacchino Del Regno
2022-11-23 11:22 ` [PATCH v2 4/4] irqchip: irq-mtk-cirq: Add support for System CIRQ on MT8192 AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cz9doctj.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).