From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE487C433FE for ; Wed, 23 Nov 2022 16:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239140AbiKWQ2w (ORCPT ); Wed, 23 Nov 2022 11:28:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239141AbiKWQ2O (ORCPT ); Wed, 23 Nov 2022 11:28:14 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FBFB5DB96; Wed, 23 Nov 2022 08:28:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC44261DB2; Wed, 23 Nov 2022 16:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F6C2C433C1; Wed, 23 Nov 2022 16:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669220891; bh=dzyLXMtXy6cZx8prGfrgAfjTZ0RmbKIX+ZoSI6qBS64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TeKWyCsb0x1vF39wYLZlLwM1ixgeT9Lc+UFTMLHCRbYi1iEX8CJ2cAtesLH7YwQRH W3cwmGxh7O3jVnag4/VBgrfUs7zNaQ2UxORA/1eUpvm+xhCWG+z2c1xVVMAsNuBGfP EA+S+OyTpggjyn3MOt0fGvKSSDnOfwXdcBAQD/Hdiz77iifLk94jZmC/uQi+TndxN5 vUDzHhJ+Aje6QGm38V4QKDMAEhrOooTxEH8sgPVL78KAMYk/IY43abnYGHB9r+NofI ZkRz9P54Xfsf6w51qsyxhviU8drf83DY7lwxEuHRo6d/EQOQ5km179S14YEf2BI+in 4VVe28o60E4jQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oxsbY-008BGI-QG; Wed, 23 Nov 2022 16:28:08 +0000 Date: Wed, 23 Nov 2022 16:28:08 +0000 Message-ID: <86cz9doctj.wl-maz@kernel.org> From: Marc Zyngier To: AngeloGioacchino Del Regno Cc: tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, youlin.pei@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array In-Reply-To: References: <20221123112249.98281-1-angelogioacchino.delregno@collabora.com> <20221123112249.98281-4-angelogioacchino.delregno@collabora.com> <86fse9ok3y.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: angelogioacchino.delregno@collabora.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, youlin.pei@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 23 Nov 2022 14:57:02 +0000, AngeloGioacchino Del Regno wrote: > > >> + enum mtk_cirq_reg_index idx, > >> + unsigned int cirq_num) > > > > What does cirq_num mean for registers that are not relative to an > > interrupt? Create a separate helper for those. > > > Means literally nothing, so yes I agree, but... > > ... mtk_cirq_irq_reg(), mtk_cirq_reg() feels too similar and may lead to > confusion while reading the code. > > Any advice about a possibly clear-er name? I think the names are OK. Passing an interrupt number as a parameter is a good discriminant anyway. Please wait for a few days before posting the next version though. M. -- Without deviation from the norm, progress is not possible.