From: "Ng, Adrian Ho Yin" <adrian.ho.yin.ng@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: socfpga: agilex: remove unimplemented clock in smmu node
Date: Wed, 13 May 2026 14:19:34 +0800 [thread overview]
Message-ID: <86ea0d5e-2a62-41ef-93b2-17b4c8dcc4f9@altera.com> (raw)
In-Reply-To: <9e777728-84ee-48ac-985d-7f2fd354b5c1@kernel.org>
On 5/8/2026 8:43 PM, Dinh Nguyen wrote:
>
>
> On 5/7/26 01:12, Adrian Ng Ho Yin wrote:
>> Remove unimplemented AGILEX_L3_MAIN_FREE_CLK in smmu node to prevent
>> probe
>> failure when smmu is enabled.
>>
>> Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
>> ---
>> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/
>> arm64/boot/dts/intel/socfpga_agilex.dtsi
>> index 0dfbafde8822..6bfee8263b3d 100644
>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
>> @@ -445,7 +445,6 @@ smmu: iommu@fa000000 {
>> <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
>> stream-match-mask = <0x7ff0>;
>> clocks = <&clkmgr AGILEX_MPU_CCU_CLK>,
>> - <&clkmgr AGILEX_L3_MAIN_FREE_CLK>,
>> <&clkmgr AGILEX_L4_MAIN_CLK>;
>> status = "disabled";
>> };
>
> Hmm. not sure about this. When I added this, the documenation had the
> clock and it's defined in include/dt-bindings/clock/agilex-clock.h. But
> you're right, it's unimplemented in the clock driver, should the fix be
> to implement it in the clock driver?
>
> Dinh
Hi Dinh,
Since the clock is documented in the TRM, i'll implement the clock in
the clock driver submit it in a separate patch. This patch will be dropped.
Thanks.
Adrian
prev parent reply other threads:[~2026-05-13 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 6:12 [PATCH] arm64: dts: socfpga: agilex: remove unimplemented clock in smmu node Adrian Ng Ho Yin
2026-05-08 12:43 ` Dinh Nguyen
2026-05-13 6:19 ` Ng, Adrian Ho Yin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ea0d5e-2a62-41ef-93b2-17b4c8dcc4f9@altera.com \
--to=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox