From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C094D8D0; Tue, 5 Nov 2024 18:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730830373; cv=none; b=WhEDYA7ntAIxLH7lLvDPcy0lKrEwYflLwfjjCzqyvsBjOpyzuSIJua9ywA50/x6EBlpK5ePyHQbsuhieeUgowwPVQo3KUU45rkyp0C3D3aI6fIqW8I4/RA5kFQ54NuMRIkP1LEB+/hmFDwjemckqCIHuY77hfPQ6rxb6WB1TVaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730830373; c=relaxed/simple; bh=Udk1VMwDN8I7xsfSbF8HU/bL4sGq932n94t1iltYcbU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=sf9MlMuJLajN+jwJKXMu6zQhn+20RYAaiZSfHX4UEci8DxDROz963bulaRSk5GqWWvp2EMXsM4Tb2THHeM0J3UQ1KjRgnuPujmg/vKavRVmBfgHQBQvfegM/Lbv+DtZMaQbJ/D0WxXe9KW//82LtxQ5X5bPF9xrDzlW14feB62Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mCmUESKy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mCmUESKy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E645C4CECF; Tue, 5 Nov 2024 18:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730830372; bh=Udk1VMwDN8I7xsfSbF8HU/bL4sGq932n94t1iltYcbU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mCmUESKyLTIVvUyIMOlG04zS+PnHc8vwsc0/A1adU//F2uIkB7NH9IIHotDtIp87J +rWhyazK/ro3FcK1OCspxRwGpwjbsbSAmcWjhGKhaXjyulTMDte378qnKHsd8BqFNG 5a89HSUKJLwizdaCgFCZsZwa63b4My277O6okqvHDz/WYozMVHRe13nhGZGNeI8ZqN JukXcqTiy1rBhoOk3Bm/xZCllGN+KLznSLwik9UF9d3kVPXgQxb5ShhqEagv8AXTLi 0/+uR0m4uv4vD2qnybmxxDL+LbinLVh9+RQJRhwry58M8tyu15d+E1/cmzbE+12dYZ M5iq8ruM8cklQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t8O2r-00A5G8-Tj; Tue, 05 Nov 2024 18:12:49 +0000 Date: Tue, 05 Nov 2024 18:12:49 +0000 Message-ID: <86ed3p1rdq.wl-maz@kernel.org> From: Marc Zyngier To: Johan Hovold Cc: Sibi Sankar , sudeep.holla@arm.com, cristian.marussi@arm.com, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com, conor+dt@kernel.org, quic_nkela@quicinc.com, quic_psodagud@quicinc.com, abel.vesa@linaro.org Subject: Re: [PATCH V7 0/2] qcom: x1e80100: Enable CPUFreq In-Reply-To: References: <20241030130840.2890904-1-quic_sibis@quicinc.com> <86plnf11yf.wl-maz@kernel.org> <86o72z10b6.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: johan@kernel.org, quic_sibis@quicinc.com, sudeep.holla@arm.com, cristian.marussi@arm.com, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com, conor+dt@kernel.org, quic_nkela@quicinc.com, quic_psodagud@quicinc.com, abel.vesa@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 05 Nov 2024 16:57:07 +0000, Johan Hovold wrote: > > On Fri, Nov 01, 2024 at 02:43:57PM +0000, Marc Zyngier wrote: > > On Fri, 01 Nov 2024 14:19:54 +0000, > > Johan Hovold wrote: > > > > The side-effects and these remaining warnings are addressed by this > > > series: > > > > > > https://lore.kernel.org/all/20241030125512.2884761-1-quic_sibis@quicinc.com/ > > > > > > but I think we should try to make the warnings a bit more informative > > > (and less scary) by printing something along the lines of: > > > > > > arm-scmi arm-scmi.0.auto: [Firmware Bug]: Ignoring duplicate OPP 3417600 for NCC > > > > > > instead. > > > > Indeed. Seeing [Firmware Bug] has a comforting feeling of > > familiarity... :) > > > > I wonder whether the same sort of reset happen on more "commercial" > > systems (such as some of the laptops). You expect that people look at > > the cpufreq stuff closely, and don't see things exploding like we are. > > I finally got around to getting my Lenovo ThinkPad T14s to boot (it > refuses to start the kernel when using GRUB, and it's not due to the > known 64 GB memory issue as it only has 32 GB) I know the feeling. My devkit can't use GRUB either, so I added a hook to the GRUB config to generate EFI scripts that directly execute the kernel with initrd, dtb, and command line. This is probably the worse firmware I've seen in a very long while. > and can confirm that it > hard resets when accessing the cpufreq sysfs attributes as well. Right. So this also happens on non-abandonware machines. > On the bright side, at least I don't see any warnings due to duplicate > OPPs on this machine (x1e78100, latest UEFI fw). One bug fixed... M. -- Without deviation from the norm, progress is not possible.